NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/56737 (WDCTL_RST errors in 9.99.92 and 9.99.93)



-------- Forwarded Message --------
Subject: CVS commit: [netbsd-10] src/sys
Date: Mon, 11 Sep 2023 14:39:21 +0000
From: Martin Husemann <martin%netbsd.org@localhost>
Reply-To: source-changes-d%NetBSD.org@localhost
To: source-changes-full%NetBSD.org@localhost

Module Name:	src
Committed By:	martin
Date:		Mon Sep 11 14:39:21 UTC 2023

Modified Files:
	src/sys/conf [netbsd-10]: files
	src/sys/dev/ic [netbsd-10]: ahcisata_core.c ahcisatavar.h
	src/sys/dev/pci [netbsd-10]: ahcisata_pci.c

Log Message:
Pull up following revision(s) (requested by abs in ticket #366):

	sys/dev/pci/ahcisata_pci.c: revision 1.70
	sys/dev/ic/ahcisata_core.c: revision 1.108
	sys/dev/ic/ahcisatavar.h: revision 1.28
	sys/conf/files: revision 1.1309

Rework AHCISATA_EXTRA_DELAY for kern/56737
- Remove AHCI_QUIRK_EXTRA_DELAY as issue appears to be drive and
  not controller related
- Replace AHCISATA_EXTRA_DELAY with AHCISATA_REMOVE_EXTRA_DELAY,
  so defaulting to enabling the extra delay, as the downside of
  slower probing on systems which do not need it is less than having
  other systems intermittently fail to probe and attach drives
- Also allow disabling extra delay with AHCISATA_EXTRA_DELAY_MS = 0

We should return to this code to work out which of the extra delays
are needed, and how long they need to be. It may be that faster
systems are more likely to trigger the issue (I've only seen it on
a 13th gen i7-13700, though only tested on a limited set)


To generate a diff of this commit:
cvs rdiff -u -r1.1304.2.1 -r1.1304.2.2 src/sys/conf/files
cvs rdiff -u -r1.107 -r1.107.4.1 src/sys/dev/ic/ahcisata_core.c
cvs rdiff -u -r1.27 -r1.27.4.1 src/sys/dev/ic/ahcisatavar.h
cvs rdiff -u -r1.68.2.1 -r1.68.2.2 src/sys/dev/pci/ahcisata_pci.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.




Home | Main Index | Thread Index | Old Index