re: bin/57856: blkdiscard abort()s when not supplying a partition name

[matthew green <mrg%eterna23.net@localhost>]

The following reply was made to PR bin/57856; it has been noted by GNATS.

From: matthew green <mrg%eterna23.net@localhost>
To: gnats-bugs%netbsd.org@localhost, code-netbsd%yoyomail.de@localhost
Cc: gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: re: bin/57856: blkdiscard abort()s when not supplying a partition name
Date: Mon, 15 Jan 2024 06:14:47 +1100

 hi.
 
 
 thanks for the PR.  i agree having easy to assert() code like this
 is bad, and i'll fix it.
 
 can you tell me what actual command you used that triggered this?
 i wonder if the code needs to understand that eg "wd0" means the
 raw partition of "wd0", since /dev/wd0 is now a valid device name
 for the same, but back when i originally wrote this code i don't
 think it was yet common or on my systems yet.
 
 eg, instead of making this an error, perhaps it should assume
 that kern.rawpartition is the partition, but first let's confirm
 what actual args you used that triggered the problem.
 
 thanks.
 
 
 .mrg.