NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/57784 CVS commit: [netbsd-8] src/external/bsd/iscsi/dist/src/lib
The following reply was made to PR port-sparc64/57784; it has been noted by GNATS.
From: "Martin Husemann" <martin%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc:
Subject: PR/57784 CVS commit: [netbsd-8] src/external/bsd/iscsi/dist/src/lib
Date: Sun, 14 Jan 2024 15:34:58 +0000
Module Name: src
Committed By: martin
Date: Sun Jan 14 15:34:58 UTC 2024
Modified Files:
src/external/bsd/iscsi/dist/src/lib [netbsd-8]: protocol.c
Log Message:
Pull up following revision(s) (requested by riastradh in ticket #1930):
external/bsd/iscsi/dist/src/lib/protocol.c: revision 1.5
libiscsi: Fix types of Time2Wait and Time2Retain in logout decap.
According to https://www.rfc-editor.org/rfc/rfc7143#section-11.15,
these are both 2-byte quantities. Loading 4-byte quantities and
passing them through ISCSI_NTOHS might have worked by accident on
x86, but it's not gonna fly on big-endian. (Fortunately sparc64 is
not just big-endian but also strict-alignment so it caught this
problem!)
XXX Is there an upstream for this code? doc/3RDPARTY doesn't cite
any easily-followed references.
PR port-sparc64/57784
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.4.24.1 src/external/bsd/iscsi/dist/src/lib/protocol.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Home |
Main Index |
Thread Index |
Old Index