Re: kern/57833: kernel panic on xorg exit

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

The following reply was made to PR kern/57833; it has been noted by GNATS.

From: "David H. Gutteridge" <david%gutteridge.ca@localhost>
To: Gnats Bugs <gnats-bugs%netbsd.org@localhost>
Cc: Taylor R Campbell <riastradh%netbsd.org@localhost>
Subject: Re: kern/57833: kernel panic on xorg exit
Date: Fri, 12 Jan 2024 19:37:16 -0500

 On 2024-01-12 17:52, Ramiro Aceves wrote:
 > El 12/1/24 a las 0:05, David H. Gutteridge escribió:
 > 
 >> The following reply was made to PR kern/57833; it has been noted by 
 >> GNATS.
 >> 
 >> From: "David H. Gutteridge" <david%gutteridge.ca@localhost>
 >> To: Taylor R Campbell <riastradh%netbsd.org@localhost>
 >> Cc: gnats-bugs%netbsd.org@localhost
 >> Subject: Re: kern/57833: kernel panic on xorg exit
 >> Date: Thu, 11 Jan 2024 18:04:44 -0500
 >> 
 >> --=_79cd473ca3d4e19fbe52c232ee5dd792
 >> Content-Transfer-Encoding: 7bit
 >> Content-Type: text/plain; charset=US-ASCII;
 >> format=flowed
 >> On 2024-01-10 23:37, Taylor R Campbell wrote:
 >>> Can you also try the attached patch, instead of the other one, to see
 >>> what happens?
 >>> 
 >>> (This might break things more spectacularly -- I haven't thought 
 >>> about
 >>> whether it makes a lot of sense -- but it should at least prevent the
 >>> particular crash you observed, if we ever get that far with it.)
 >> I've supplied a debug log. (It can be found at:
 >> https://www.netbsd.org/~gutteridge/pr57833_debug.log .)
 >> Applying the first (small) patch did not prevent the panics. But the
 >> larger patch did fix the problem for me. There was a slight coding
 >> error with the second patch (wrong label for a goto statement), so it
 >> didn't compile as-is. I've attached a revised patch that fixes that 
 >> one
 >> line, should anyone else want to test this.
 >> Thanks,
 >> Dave
 > 
 > Hello Dave, thanks for feedback. Here I had the same problem, I applied 
 > the patch and could not compile the kernel  because en error in 555 
 > line when compiling i915_gem_stolen.c file. I changed
 > 
 > goto err;
 > 
 > to
 > 
 > goto out;
 > 
 > (not sure if that is the right fix)
 
 Yes, it is.
 
 > File compiled ok. Rebuilt the kernel and I had the same panic the first 
 > time abandoned Xorg session.
 
 There must be something different about your hardware than mine here,
 then. (Mine is Intel 945GME.) The patch did work for me, but I guess
 there's more to it.
 
 Do you have a build that includes a netbsd.gdb file? If not, you can
 generate one (e.g., for your patched kernel) by un-commenting the
 line
 
 makeoptions	DEBUG="-g"
 
 in your kernel config file (I assume GENERIC?) and re-building. The
 extra file should appear.
 
 Then we would have the means to get the other details Taylor is looking
 for here (see the email from Thu, 11 Jan 2024 03:45UTC).
 
 Dave
 
 PS Sorry I was not able to send you a patch again earlier. GMail is not
 accepting email from my domain, so my email bounced. Evidently my emails
 do make it when funnelled through GNATS.