Re: kern/57833: kernel panic on xorg exit

[Ramiro Aceves <ea1abz%gmail.com@localhost>]

El 12/1/24 a las 0:05, David H. Gutteridge escribió:
> The following reply was made to PR kern/57833; it has been noted by GNATS.
>
> From: "David H. Gutteridge" <david%gutteridge.ca@localhost>
> To: Taylor R Campbell <riastradh%netbsd.org@localhost>
> Cc: gnats-bugs%netbsd.org@localhost
> Subject: Re: kern/57833: kernel panic on xorg exit
> Date: Thu, 11 Jan 2024 18:04:44 -0500
>
>   --=_79cd473ca3d4e19fbe52c232ee5dd792
>   Content-Transfer-Encoding: 7bit
>   Content-Type: text/plain; charset=US-ASCII;
>    format=flowed
>   
>   On 2024-01-10 23:37, Taylor R Campbell wrote:
>   > Can you also try the attached patch, instead of the other one, to see
>   > what happens?
>   >
>   > (This might break things more spectacularly -- I haven't thought about
>   > whether it makes a lot of sense -- but it should at least prevent the
>   > particular crash you observed, if we ever get that far with it.)
>   
>   I've supplied a debug log. (It can be found at:
>   https://www.netbsd.org/~gutteridge/pr57833_debug.log .)
>   
>   Applying the first (small) patch did not prevent the panics. But the
>   larger patch did fix the problem for me. There was a slight coding
>   error with the second patch (wrong label for a goto statement), so it
>   didn't compile as-is. I've attached a revised patch that fixes that one
>   line, should anyone else want to test this.
>   
>   Thanks,
>   
>   Dave


Hello Dave, thanks for feedback. Here I had the same problem, I applied 
the patch and could not compile the kernel  because en error in 555 line 
when compiling i915_gem_stolen.c file. I changed

goto err;

to

goto out;

(not sure if that is the right fix)

File compiled ok. Rebuilt the kernel and I had the same panic the first 
time abandoned Xorg session.

Ramiro.




>   
>   --=_79cd473ca3d4e19fbe52c232ee5dd792
>   Content-Transfer-Encoding: base64
>   Content-Type: text/x-diff;
>    name=pr57833-i915gempages-v2.patch
>   Content-Disposition: attachment;
>    filename=pr57833-i915gempages-v2.patch;
>    size=4173
>   
>   ZGlmZiAtLWdpdCBhL3N5cy9leHRlcm5hbC9ic2QvZHJtMi9kaXN0L2RybS9pOTE1L2dlbS9pOTE1
>   X2dlbV9tbWFuLmMgYi9zeXMvZXh0ZXJuYWwvYnNkL2RybTIvZGlzdC9kcm0vaTkxNS9nZW0vaTkx
>   NV9nZW1fbW1hbi5jCmluZGV4IDhlNTkyZjAwOGVmNy4uMjc2ZWJiZGJjMjM0IDEwMDY0NAotLS0g
>   YS9zeXMvZXh0ZXJuYWwvYnNkL2RybTIvZGlzdC9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fbW1hbi5j
>   CisrKyBiL3N5cy9leHRlcm5hbC9ic2QvZHJtMi9kaXN0L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9t
>   bWFuLmMKQEAgLTY3Nyw2ICs2NzcsOCBAQCB2b2lkIGk5MTVfZ2VtX29iamVjdF9yZWxlYXNlX21t
>   YXBfb2Zmc2V0KHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmopCiAJCXJldHVybjsKIAlm
>   b3IgKGkgPSAwOyBpIDwgb2JqLT5iYXNlLnNpemUgPj4gUEFHRV9TSElGVDsgaSsrKSB7CiAJCXBh
>   Z2UgPSBvYmotPm1tLnBhZ2VzLT5zZ2wtPnNnX3Bnc1tpXTsKKwkJaWYgKHBhZ2UgPT0gTlVMTCkK
>   KwkJCWNvbnRpbnVlOwogCQl2bV9wYWdlID0gJnBhZ2UtPnBfdm1wOwogCQlwbWFwX3BhZ2VfcHJv
>   dGVjdCh2bV9wYWdlLCBWTV9QUk9UX05PTkUpOwogCX0KZGlmZiAtLWdpdCBhL3N5cy9leHRlcm5h
>   bC9ic2QvZHJtMi9kaXN0L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9waHlzLmMgYi9zeXMvZXh0ZXJu
>   YWwvYnNkL2RybTIvZGlzdC9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fcGh5cy5jCmluZGV4IDNmNjgy
>   NzZlZWE1Zi4uMjk3NzJiZGJkOGQ5IDEwMDY0NAotLS0gYS9zeXMvZXh0ZXJuYWwvYnNkL2RybTIv
>   ZGlzdC9kcm0vaTkxNS9nZW0vaTkxNV9nZW1fcGh5cy5jCisrKyBiL3N5cy9leHRlcm5hbC9ic2Qv
>   ZHJtMi9kaXN0L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9waHlzLmMKQEAgLTgzLDggKzgzLDE0IEBA
>   IHN0YXRpYyBpbnQgaTkxNV9nZW1fb2JqZWN0X2dldF9wYWdlc19waHlzKHN0cnVjdCBkcm1faTkx
>   NV9nZW1fb2JqZWN0ICpvYmopCiAJaWYgKCFzdCkKIAkJZ290byBlcnJfcGNpOwogCisjaWZkZWYg
>   X19OZXRCU0RfXworCWlmIChzZ19hbGxvY190YWJsZV9mcm9tX2J1c19kbWFtZW0oc3QsIGRtYXQs
>   ICZvYmotPm1tLnUucGh5cy5zZWcsIDEsCisJCUdGUF9LRVJORUwpKQorCQlnb3RvIGVycl9zdDsK
>   KyNlbHNlCiAJaWYgKHNnX2FsbG9jX3RhYmxlKHN0LCAxLCBHRlBfS0VSTkVMKSkKIAkJZ290byBl
>   cnJfc3Q7CisjZW5kaWYKIAogCXNnID0gc3QtPnNnbDsKICNpZmRlZiBfX05ldEJTRF9fCmRpZmYg
>   LS1naXQgYS9zeXMvZXh0ZXJuYWwvYnNkL2RybTIvZGlzdC9kcm0vaTkxNS9nZW0vaTkxNV9nZW1f
>   cmVnaW9uLmMgYi9zeXMvZXh0ZXJuYWwvYnNkL2RybTIvZGlzdC9kcm0vaTkxNS9nZW0vaTkxNV9n
>   ZW1fcmVnaW9uLmMKaW5kZXggMWE5Mjg5ODhiZDVmLi41ZTgyMzJiOTYzNGYgMTAwNjQ0Ci0tLSBh
>   L3N5cy9leHRlcm5hbC9ic2QvZHJtMi9kaXN0L2RybS9pOTE1L2dlbS9pOTE1X2dlbV9yZWdpb24u
>   YworKysgYi9zeXMvZXh0ZXJuYWwvYnNkL2RybTIvZGlzdC9kcm0vaTkxNS9nZW0vaTkxNV9nZW1f
>   cmVnaW9uLmMKQEAgLTg1LDcgKzg1LDE1IEBAIGk5MTVfZ2VtX29iamVjdF9nZXRfcGFnZXNfYnVk
>   ZHkoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikKIAogCQlzZWdzW2ldLmRzX2FkZHIg
>   PSBtZW0tPnJlZ2lvbi5zdGFydCArIG9mZnNldDsKIAkJc2Vnc1tpXS5kc19sZW4gPSBibG9ja19z
>   aXplOworCQlpKys7CiAJfQorCUtBU1NFUlQoaSA9PSBuc2Vncyk7CisKKwkvKiBYWFggZXJybm8g
>   TmV0QlNELT5MaW51eCAqLworCXJldCA9IC1idXNfZG1hbWVtX2V4cG9ydF9wYWdlcyhkbWF0LCBz
>   ZWdzLCBuc2Vncywgc2ctPnNnX3BncywKKwkgICAgc2ctPnNnX25wZ3MpOworCWlmIChyZXQpCisJ
>   CWdvdG8gZXJyOwogCiAJLyogWFhYIGVycm5vIE5ldEJTRC0+TGludXggKi8KIAlyZXQgPSAtYnVz
>   X2RtYW1hcF9jcmVhdGUoZG1hdCwgc2l6ZSwgbnNlZ3MsIHNpemUsIDAsIEJVU19ETUFfV0FJVE9L
>   LApkaWZmIC0tZ2l0IGEvc3lzL2V4dGVybmFsL2JzZC9kcm0yL2Rpc3QvZHJtL2k5MTUvZ2VtL2k5
>   MTVfZ2VtX3N0b2xlbi5jIGIvc3lzL2V4dGVybmFsL2JzZC9kcm0yL2Rpc3QvZHJtL2k5MTUvZ2Vt
>   L2k5MTVfZ2VtX3N0b2xlbi5jCmluZGV4IGI1M2Q1NDNmYTg5NC4uMDhjZjdmMDAwMWJmIDEwMDY0
>   NAotLS0gYS9zeXMvZXh0ZXJuYWwvYnNkL2RybTIvZGlzdC9kcm0vaTkxNS9nZW0vaTkxNV9nZW1f
>   c3RvbGVuLmMKKysrIGIvc3lzL2V4dGVybmFsL2JzZC9kcm0yL2Rpc3QvZHJtL2k5MTUvZ2VtL2k5
>   MTVfZ2VtX3N0b2xlbi5jCkBAIC01MDYsMTQgKzUwNiwxMyBAQCBpOTE1X3BhZ2VzX2NyZWF0ZV9m
>   b3Jfc3RvbGVuKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCiB7CiAJc3RydWN0IGRybV9pOTE1X3By
>   aXZhdGUgKmk5MTUgPSB0b19pOTE1KGRldik7CiAJc3RydWN0IHNnX3RhYmxlICpzdDsKKwlzdHJ1
>   Y3Qgc2NhdHRlcmxpc3QgKnNnOwogI2lmZGVmIF9fTmV0QlNEX18KIAlidXNfZG1hX3RhZ190IGRt
>   YXQgPSBpOTE1LT5kcm0uZG1hdDsKIAlidXNfZG1hX3NlZ21lbnRfdCAqc2VnID0gTlVMTDsKIAlp
>   bnQgbnNlZyA9IDAsIGk7CiAJYm9vbCBsb2FkZWQgPSBmYWxzZTsKIAlpbnQgcmV0OwotI2Vsc2UK
>   LQlzdHJ1Y3Qgc2NhdHRlcmxpc3QgKnNnOwogI2VuZGlmCiAKIAlHRU1fQlVHX09OKHJhbmdlX292
>   ZXJmbG93cyhvZmZzZXQsIHNpemUsIHJlc291cmNlX3NpemUoJmk5MTUtPmRzbSkpKTsKQEAgLTUz
>   Miw2ICs1MzEsNyBAQCBpOTE1X3BhZ2VzX2NyZWF0ZV9mb3Jfc3RvbGVuKHN0cnVjdCBkcm1fZGV2
>   aWNlICpkZXYsCiAJCXJldHVybiBFUlJfUFRSKC1FTk9NRU0pOwogCX0KIAorCXNnID0gc3QtPnNn
>   bDsKICNpZmRlZiBfX05ldEJTRF9fCiAJS0FTU0VSVCgoc2l6ZSAlIFBBR0VfU0laRSkgPT0gMCk7
>   CiAJbnNlZyA9IHNpemUgLyBQQUdFX1NJWkU7CkBAIC01NDgsMTkgKzU0OCwyNSBAQCBpOTE1X3Bh
>   Z2VzX2NyZWF0ZV9mb3Jfc3RvbGVuKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCiAJCXNlZ1tpXS5k
>   c19sZW4gPSBQQUdFX1NJWkU7CiAJfQogCisJLyogWFhYIGVycm5vIE5ldEJTRC0+TGludXggKi8K
>   KwlyZXQgPSAtYnVzX2RtYW1lbV9leHBvcnRfcGFnZXMoZG1hdCwgc2VnLCBuc2VnLCBzZy0+c2df
>   cGdzLAorCSAgICBzZy0+c2dfbnBncyk7CisJaWYgKHJldCkKKwkJZ290byBvdXQ7CisKIAkvKiBY
>   WFggZXJybm8gTmV0QlNELT5MaW51eCAqLwogCXJldCA9IC1idXNfZG1hbWFwX2NyZWF0ZShkbWF0
>   LCBzaXplLCBuc2VnLCBQQUdFX1NJWkUsIDAsCi0JICAgIEJVU19ETUFfV0FJVE9LLCAmc3QtPnNn
>   bC0+c2dfZG1hbWFwKTsKKwkgICAgQlVTX0RNQV9XQUlUT0ssICZzZy0+c2dfZG1hbWFwKTsKIAlp
>   ZiAocmV0KSB7CiAJCURSTV9FUlJPUigiZmFpbGVkIHRvIGNyZWF0ZSBETUEgbWFwIGZvciBzdG9s
>   ZW4gb2JqZWN0OiAlZFxuIiwKIAkJICAgIHJldCk7Ci0JCXN0LT5zZ2wtPnNnX2RtYW1hcCA9IE5V
>   TEw7CisJCXNnLT5zZ19kbWFtYXAgPSBOVUxMOwogCQlnb3RvIG91dDsKIAl9Ci0Jc3QtPnNnbC0+
>   c2dfZG1hdCA9IGRtYXQ7CisJc2ctPnNnX2RtYXQgPSBkbWF0OwogCiAJLyogWFhYIGVycm5vIE5l
>   dEJTRC0+TGl1eCAqLwotCXJldCA9IC1idXNfZG1hbWFwX2xvYWRfcmF3KGRtYXQsIHN0LT5zZ2wt
>   PnNnX2RtYW1hcCwgc2VnLCBuc2VnLCBzaXplLAorCXJldCA9IC1idXNfZG1hbWFwX2xvYWRfcmF3
>   KGRtYXQsIHNnLT5zZ19kbWFtYXAsIHNlZywgbnNlZywgc2l6ZSwKIAkgICAgQlVTX0RNQV9XQUlU
>   T0spOwogCWlmIChyZXQpIHsKIAkJRFJNX0VSUk9SKCJmYWlsZWQgdG8gbG9hZCBETUEgbWFwIGZv
>   ciBzdG9sZW4gb2JqZWN0OiAlZFxuIiwKQEAgLTU3MSwxMyArNTc3LDEyIEBAIGk5MTVfcGFnZXNf
>   Y3JlYXRlX2Zvcl9zdG9sZW4oc3RydWN0IGRybV9kZXZpY2UgKmRldiwKIAogb3V0OglpZiAocmV0
>   KSB7CiAJCWlmIChsb2FkZWQpCi0JCQlidXNfZG1hbWFwX3VubG9hZChkbWF0LCBzdC0+c2dsLT5z
>   Z19kbWFtYXApOworCQkJYnVzX2RtYW1hcF91bmxvYWQoZG1hdCwgc2ctPnNnX2RtYW1hcCk7CiAJ
>   CXNnX2ZyZWVfdGFibGUoc3QpOwogCQlrZnJlZShzdCk7CiAJCXJldHVybiBFUlJfUFRSKHJldCk7
>   CiAJfQogI2Vsc2UKLQlzZyA9IHN0LT5zZ2w7CiAJc2ctPm9mZnNldCA9IDA7CiAJc2ctPmxlbmd0
>   aCA9IHNpemU7CiAK
>   --=_79cd473ca3d4e19fbe52c232ee5dd792--
>