PR/57784 CVS commit: src/external/bsd/iscsi/dist/src/lib

["Taylor R Campbell" <riastradh%netbsd.org@localhost>]

The following reply was made to PR port-sparc64/57784; it has been noted by GNATS.

From: "Taylor R Campbell" <riastradh%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/57784 CVS commit: src/external/bsd/iscsi/dist/src/lib
Date: Tue, 19 Dec 2023 02:16:08 +0000

 Module Name:	src
 Committed By:	riastradh
 Date:		Tue Dec 19 02:16:07 UTC 2023
 
 Modified Files:
 	src/external/bsd/iscsi/dist/src/lib: protocol.c
 
 Log Message:
 libiscsi: Fix types of Time2Wait and Time2Retain in logout decap.
 
 According to https://www.rfc-editor.org/rfc/rfc7143#section-11.15,
 these are both 2-byte quantities.  Loading 4-byte quantities and
 passing them through ISCSI_NTOHS might have worked by accident on
 x86, but it's not gonna fly on big-endian.  (Fortunately sparc64 is
 not just big-endian but also strict-alignment so it caught this
 problem!)
 
 XXX Is there an upstream for this code?  doc/3RDPARTY doesn't cite
 any easily-followed references.
 
 PR port-sparc64/57784
 
 XXX pullup-10
 XXX pullup-9
 XXX pullup-8
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/external/bsd/iscsi/dist/src/lib/protocol.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.