PR/57324 CVS commit: src/sys/arch/evbarm/evbarm

["matthew green" <mrg%netbsd.org@localhost>]

The following reply was made to PR port-arm/57324; it has been noted by GNATS.

From: "matthew green" <mrg%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/57324 CVS commit: src/sys/arch/evbarm/evbarm
Date: Sat, 28 Oct 2023 17:53:06 +0000

 Module Name:	src
 Committed By:	mrg
 Date:		Sat Oct 28 17:53:06 UTC 2023
 
 Modified Files:
 	src/sys/arch/evbarm/evbarm: autoconf.c
 
 Log Message:
 allow "root=xxx" command line to override platform defaults.
 
 PR#57324 shows that on broadcom evbarm systems the default root
 is no longer chosen, even when specified on the command line.
 
 sc.dying and mlelstv pointed out that revision 1.24 made this
 function skip parsing "root=" if already set, which was not what
 i expected to happen anywhere here (and it works fine on FDT and
 UEFI boots.)
 
 revert that part of 1.24.
 
 XXX: pullup-10.
 
 (while this is it's own bug, it points out that
 bcm283x_platform_device_register() currently will set
 booted_device to the first ld@sdmmc found, even if that device was
 not involved with booting.  while fixing this would be nice, it
 wouldn't have helped with this setup -- choosing ld@sdmmc is the
 right answer in eg PR#57324 at this point, so having it set in
 this case should be fine, and then overrideable via root=.)
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.24 -r1.25 src/sys/arch/evbarm/evbarm/autoconf.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.