Re: kern/57645: bridge does not work on raspberry pi

[mlelstv%serpens.de@localhost (Michael van Elst)]

The following reply was made to PR kern/57645; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/57645: bridge does not work on raspberry pi
Date: Sun, 8 Oct 2023 13:21:43 -0000 (UTC)

 sc.dying%gmail.com@localhost writes:
 
 > >  -	if ((changed & ~(IFF_CANTCHANGE | IFF_DEBUG)) == 0) {
 > >  +	if ((changed & ~(IFF_CANTCHANGE | IFF_DEBUG)) != 0) {
 
 > I don't think this code works as expected,
 > as IFF_CANTCHANGE includes IFF_PROMISC.
 > 
 > 	if ((changed & (~(IFF_CANTCHANGE | IFF_DEBUG) | IFF_PROMISC)) != 0) {
 
 The interesting part is, that it does work, probably because at some
 point IFF_UP changes and 'changed' isn't masked.
 
 The IFF_CANTCHANGE mask doesn't look correct to me.