NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/57133



Had a quick check for related comparisons:
 '(xs->resid.*\S=.*xs->datalen|xs->datalen.*\S=.*xs->resid)' in the
source tree. Looks like its been pretty consistent through at least 8,
9 10 & current:

sys/arch/bebox/stand/boot/siop.c:957:                   if (xs->resid
== xs->datalen && xs->datalen) {
sys/arch/prep/stand/boot/siop.c:919:                    if (xs->resid
== xs->datalen && xs->datalen) {
sys/dev/pci/mpii.c:3207:        KASSERT(xs->resid == xs->datalen);
sys/dev/scsipi/atapi_base.c:89:                 if (xs->resid == xs->datalen)
sys/dev/scsipi/st.c:2262:               if (xs->datalen && xs->resid
>= xs->datalen) {
sys/dev/scsipi/scsipi_base.c:983:                       if (xs->resid
== xs->datalen && xs->datalen) {

mpii.c definitely seems to be the only assert in there, so presumably
as long as its doing the Right Thing with the returned data, the
assert should be removed...

David


Home | Main Index | Thread Index | Old Index