Re: toolchain/57584: Running build.sh with -N 3 or -N 4 causes debug logging to be included in the MKVARS shell variable in distrib/sets/sets.subr

[Palle Lyckegaard <palle%lyckegaard.dk@localhost>]

The following reply was made to PR toolchain/57584; it has been noted by GNATS.

From: Palle Lyckegaard <palle%lyckegaard.dk@localhost>
To: Christos Zoulas <christos%zoulas.com@localhost>
Cc: gnats-bugs%netbsd.org@localhost, toolchain-manager%netbsd.org@localhost,
        gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: toolchain/57584: Running build.sh with -N 3 or -N 4 causes debug
 logging to be included in the MKVARS shell variable in
 distrib/sets/sets.subr
Date: Wed, 30 Aug 2023 17:27:16 +0000 (UTC)

 On Tue, 29 Aug 2023, Christos Zoulas wrote:
 
 > 
 > The current version in sets.subr contains:
 >
 > [3:13pm] 226>grep mkvars.mk sets.subr
 > for x in $( MAKEVERBOSE= ${MAKE} -B -f ${rundir}/mkvars.mk mkvars ); do
 > MKVARS="$( MAKEVERBOSE= ${MAKE} -B -f ${rundir}/mkvars.mk mkvars | ${SED} -e 's,=.*,,' | ${XARGS} )"
 > #       make -f mkvars.mk mkvarsyesno
 > #       make -f mkvars.mk mkextravars
 >
 > Doesn't that work for you? I made that change in 2017...:
 >
 > revision 1.180
 > date: 2017-11-22 16:31:20 -0500;  author: christos;  state: Exp;  lines: +6 -6;  commitid: aVq742vybyN8T4gA;
 > Ignore MAKEVERBOSE for snippet makefiles.
 >
 >
 
 
 oops - sorry.... I accidently removed MAKEVERBOSE from the line.
 
 Here is my current attempt to fix the issue, but that still fails
 
 diff --git a/distrib/sets/sets.subr b/distrib/sets/sets.subr
 index 6f2223181713..b4563ad5153f 100644
 --- a/distrib/sets/sets.subr
 +++ b/distrib/sets/sets.subr
 @@ -129,7 +129,7 @@ done
 
   IFS=$oIFS
 
 -MKVARS="$( MAKEVERBOSE= ${MAKE} -B -f ${rundir}/mkvars.mk mkvars | ${SED} 
 -e 's,=.*,,' | ${XARGS} )"
 +MKVARS="$( MAKEVERBOSE= ${MAKE} -d -l -d -x -B -f ${rundir}/mkvars.mk 
 mkvars | ${SED} -e 's,=.*,,' | ${XARGS} )"
 
   #####
 
 
 
 I'm basically trying to revert the addition of the '-d l' and '-d x' flags 
 to the MAKEFLAGS variable.
 Reading make(1) seems to indicate that a '-' can be used to revert these 
 flags, but perhaps I am misunderstanding the documentation