Re: port-sparc/57594: openssl speed crashes on sparcv8

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR port-sparc/57594; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: port-sparc/57594: openssl speed crashes on sparcv8
Date: Tue, 29 Aug 2023 20:30:45 +0200

 It seems I can only reproduce this when running with ASLR enabled.
 Starting openssl from gdb makes it work.
 
 The upstream code has a minor bug and fixing that seems to avoid the
 problem, but I'm not really clear why... (changing condition codes in
 the branch delay slot of a conditional branch considered evil?)
 
 Martin
 
 Index: sparccpuid.S
 ===================================================================
 RCS file: /cvsroot/src/crypto/external/bsd/openssl/dist/crypto/sparccpuid.S,v
 retrieving revision 1.10
 diff -u -r1.10 sparccpuid.S
 --- sparccpuid.S	7 May 2023 18:40:16 -0000	1.10
 +++ sparccpuid.S	29 Aug 2023 18:19:28 -0000
 @@ -364,12 +364,12 @@
  .align	32
  OPENSSL_cleanse:
  	cmp	%o1,14
 -	nop
  #ifdef ABI64
  	bgu	%xcc,.Lot
  #else
  	bgu	.Lot
  #endif
 +	nop
  	cmp	%o1,0
  	bne	.Little
  	nop