Re: toolchain/57584: Running build.sh with -N 3 or -N 4 causes debug logging to be included in the MKVARS shell variable in distrib/sets/sets.subr

[Christos Zoulas <christos%zoulas.com@localhost>]

The following reply was made to PR toolchain/57584; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: toolchain-manager%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 palle%lyckegaard.dk@localhost
Subject: Re: toolchain/57584: Running build.sh with -N 3 or -N 4 causes debug
 logging to be included in the MKVARS shell variable in distrib/sets/sets.subr
Date: Tue, 29 Aug 2023 07:57:33 -0400

 --Apple-Mail=_33A6C108-8CDF-46F7-BE77-A0C26332BBFE
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 I think it is a lot simpler to not generate the echo's in the first =
 place :-)
 
 env MAKEVERBOSE=3D4 make -f mkvars.mk mkvars MAKEVERBOSE=3D0
 
 christos
 
 > On Aug 28, 2023, at 3:55 PM, Palle Lyckegaard <palle%lyckegaard.dk@localhost> =
 wrote:
 >=20
 > The following reply was made to PR toolchain/57584; it has been noted =
 by GNATS.
 >=20
 > From: Palle Lyckegaard <palle%lyckegaard.dk@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: toolchain-manager%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
 >        netbsd-bugs%netbsd.org@localhost
 > Subject: Re: toolchain/57584: Running build.sh with -N 3 or -N 4 =
 causes debug
 > logging to be included in the MKVARS shell variable in
 > distrib/sets/sets.subr
 > Date: Mon, 28 Aug 2023 19:50:02 +0000 (UTC)
 >=20
 > On Fri, 18 Aug 2023, Palle Lyckegaard wrote:
 >=20
 >> I've managed to fix the issue with the following patch (removing =
 lines
 >> with the string 'echo'):
 >>=20
 >> diff --git a/distrib/sets/sets.subr b/distrib/sets/sets.subr
 >> index 6f2223181713..61546167b956 100644
 >> --- a/distrib/sets/sets.subr
 >> +++ b/distrib/sets/sets.subr
 >> @@ -129,7 +129,7 @@ done
 >>=20
 >>  IFS=3D$oIFS
 >>=20
 >> -MKVARS=3D"$( MAKEVERBOSE=3D ${MAKE} -B -f ${rundir}/mkvars.mk mkvars =
 | ${SED}
 >> -e 's,=3D.*,,' | ${XARGS} )"
 >> +MKVARS=3D"$( MAKEVERBOSE=3D ${MAKE} -B -f ${rundir}/mkvars.mk mkvars =
 | ${SED}
 >> -e 's,=3D.*,,' -e 's,echo.*,,'| ${XARGS} )"
 >>=20
 >>  #####
 >>=20
 >=20
 >=20
 >=20
 > Updated patch:
 >=20
 > diff --git a/distrib/sets/sets.subr b/distrib/sets/sets.subr
 > index 6f2223181713..77babdaa8f04 100644
 > --- a/distrib/sets/sets.subr
 > +++ b/distrib/sets/sets.subr
 > @@ -129,7 +129,10 @@ done
 >=20
 >   IFS=3D$oIFS
 >=20
 > -MKVARS=3D"$( MAKEVERBOSE=3D ${MAKE} -B -f ${rundir}/mkvars.mk mkvars =
 | ${SED}
 > -e 's,=3D.*,,' | ${XARGS} )"
 > +# The construction of the MKVARS variable includes some filtering out =
 of
 > the string 'echo' since
 > +# mkvars.mk has a number of "@echo" commands that pollutes the output
 > when building with MAKEVERBOSE=3D3 or
 > +# MAKEVERBOSE=3D4
 > +MKVARS=3D"$( MAKEVERBOSE=3D ${MAKE} -B -f ${rundir}/mkvars.mk mkvars =
 |
 > ${GREP} -v 'echo' | ${SED} -e 's,=3D.*,,' | ${XARGS} )"
 >=20
 >   #####
 >=20
 >=20
 > Comments?
 >=20
 
 
 --Apple-Mail=_33A6C108-8CDF-46F7-BE77-A0C26332BBFE
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCZO3dLQAKCRBxESqxbLM7
 OnWDAJ9rzmMMFR0karPsEcxDKTbywxBw3gCgyV0gOcso/0vUrxsxENBMajFqK5A=
 =LtPw
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_33A6C108-8CDF-46F7-BE77-A0C26332BBFE--