lib/57461: crypto/external/bsd/openssl/lib needs build_install treatment

[campbell+netbsd%mumble.net@localhost]

>Number:         57461
>Category:       lib
>Synopsis:       crypto/external/bsd/openssl/lib needs build_install treatment
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 09 23:20:00 +0000 2023
>Originator:     Taylor R Campbell
>Release:        current
>Organization:
The NetBuildinstall Foundation
>Environment:
>Description:
On update from the openssl11 era to the openssl3 era, updates builds often lead to libssl.so.15 linked against libcrypto.so.14.

This is a consistent problem that many people have hit.  We discussed this on IRC but I forget the details.  Probably crypto/external/bsd/openssl/lib needs the build_install treatment -- either lib/Makefile needs to list each openssl library directly, or we need a way to use bsd.buildinstall.mk in crypto/external/bsd/openssl/lib/Makefile, so that the installed libcrypto.so symlink is definitely updated before libssl.so can be linked.

Incidence of this particular manifestation of the problem will likely diminish as people update their trees to openssl3 and nuke the objdirs to get clean builds, but the underlying problem will likely remain and waste hours of debugging silly problems like when we next have libssl.so.16.
>How-To-Repeat:
build.sh with openssl11
build.sh -u with openssl3
>Fix:
Yes, please!