Re: port-macppc/57394: CPU unable to attach mainbus on NetBSD 10.0_BETA(Current?) on Power Macintosh 9600(G2)

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR port-macppc/57394; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: port-macppc-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
	netbsd-bugs%netbsd.org@localhost, nullnilaki%gmail.com@localhost
Subject: Re: port-macppc/57394: CPU unable to attach mainbus on NetBSD
 10.0_BETA(Current?) on Power Macintosh 9600(G2)
Date: Tue, 9 May 2023 11:24:10 +0200

 On Tue, May 09, 2023 at 08:55:01AM +0000, Michael wrote:
 >  >  The test should be != -1, see
 >  >  https://nxr.netbsd.org/xref/src/sys/arch/powerpc/powerpc/openfirm.c#345
 >  
 >  I dimly remember some Apple OF variants returning 0 on (some) errors,
 >  there was a reason why checks for 0 or -1 are littered all over the
 >  place other than my forgetfulness.
 
 OK, in that case (the OF call works but returns 0) we need to check for
 both -1 and 0 here.
 
 Martin