port-macppc/57394: CPU unable to attach mainbus on NetBSD 10.0_BETA(Current?) on Power Macintosh 9600(G2)

[nullnilaki%gmail.com@localhost]

>Number:         57394
>Category:       port-macppc
>Synopsis:       CPU unable to attach mainbus on NetBSD 10.0_BETA(Current?) on Power Macintosh 9600(G2)
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    port-macppc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 06 22:05:00 +0000 2023
>Originator:     Naruaki Etomi
>Release:        NetBSD 10.0_BETA
>Organization:
>Environment:
# uname -a
NetBSD  10.0_BETA NetBSD 10.0_BETA (GENERIC) #12: Sat May  6 21:41:55 UTC 2023  naruaki@localhost:/usr/obj.macppc/sys/arch/macppc/compile/GENERIC macppc
>Description:
OF_finddevice("/cpus") function return -1 on G2 Mac... 
https://nxr.netbsd.org/xref/src/sys/arch/macppc/macppc/mainbus.c?r=1.25#78

---------------------------------------------------------------------------------------------

>> NetBSD/macppc OpenFirmware Boot, Revision 1.13 (Thu Aug  4 15:30:37 UTC 2022)
no active packageno active package11764700+167212 [485280+462037]=0xc48ae0
 start=0x100000
[   1.0000000] Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003,
[   1.0000000]     2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013,
[   1.0000000]     2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021, 2022, 2023
[   1.0000000]     The NetBSD Foundation, Inc.  All rights reserved.
[   1.0000000] Copyright (c) 1982, 1986, 1989, 1991, 1993
[   1.0000000]     The Regents of the University of California.  All rights reserved.

[   1.0000000] NetBSD 10.0_BETA (GENERIC) #11: Sat May  6 21:22:58 UTC 2023
[   1.0000000] 	naruaki@localhost:/usr/obj.macppc/sys/arch/macppc/compile/GENERIC
[   1.0000000] total memory = 98304 KB
[   1.0000000] avail memory = 81412 KB
[   1.0000000] found Grand Central PIC at f3000000
[   1.0000000] bootpath: scsi/sd@0/netbsd
[   1.0000000] mainbus0 (root)
[   1.0000000] memory0 at mainbus0
[   1.0000000] bandit0 at mainbus0

>How-To-Repeat:
Boot  NetBSD 10.0_BETA on G2 Mac
>Fix:
diff -Naru macppc.orig/mainbus.c macppc/mainbus.c
--- macppc.orig/mainbus.c       2023-05-06 21:29:45.203239936 +0000
+++ macppc/mainbus.c    2023-05-06 21:37:04.495657936 +0000
@@ -76,7 +76,7 @@
        devhandle_t selfh = device_handle(self);

        cpus = OF_finddevice("/cpus");
-       if (cpus != 0) {
+       if (cpus > 0) {
                node = OF_child(cpus);
                while (node != 0) {
                        ca.ca_name = "cpu";

---------------------------------------------------------------------------------------------

>> NetBSD/macppc OpenFirmware Boot, Revision 1.13 (Thu Aug  4 15:30:37 UTC 2022)
no active packageno active package11764700+167212 [485280+462037]=0xc48ae0
 start=0x100000
[   1.0000000] Copyright (c) 1996, 1997, 1998, 1999, 2000, 2001, 2002, 2003,
[   1.0000000]     2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013,
[   1.0000000]     2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021, 2022, 2023
[   1.0000000]     The NetBSD Foundation, Inc.  All rights reserved.
[   1.0000000] Copyright (c) 1982, 1986, 1989, 1991, 1993
[   1.0000000]     The Regents of the University of California.  All rights reserved.

[   1.0000000] NetBSD 10.0_BETA (GENERIC) #12: Sat May  6 21:41:55 UTC 2023
[   1.0000000] 	naruaki@localhost:/usr/obj.macppc/sys/arch/macppc/compile/GENERIC
[   1.0000000] total memory = 98304 KB
[   1.0000000] avail memory = 81412 KB
[   1.0000000] found Grand Central PIC at f3000000
[   1.0000000] bootpath: scsi/sd@0/netbsd
[   1.0000000] mainbus0 (root)
[   1.0000000] cpu0 at mainbus0: 604e (Revision 2.2), ID 0 (primary)
[   1.0000000] cpu0: HID0 0x8000c084<EMCP,ICE,DCE,SGE,BHT>, powersave: 1
[   1.0000000] cpu0: 200.00 MHz
[   1.0000000] cpu1 at mainbus0: ID 1
[   1.0000000] cpu1: processor off-line; multiprocessor support not present in kernel
[   1.0000000] memory0 at mainbus0
[   1.0000000] bandit0 at mainbus0
[   1.0000000] pci0 at bandit0 bus 0
[   1.0000000] pchb0 at pci0 dev 11 function 0