misc/57284: Unit test for envstat fails in ATF Tests suite on one machine

[jspath55%gmail.com@localhost]

>Number:         57284
>Category:       misc
>Synopsis:       Unit test for envstat fails in ATF Tests suite on one machine
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 22 19:55:00 +0000 2023
>Originator:     Jim Spath
>Release:        10.0_BETA
>Organization:
>Environment:
NetBSD one.machine 10.0_BETA NetBSD 10.0_BETA (GENERIC) #0: Sun Feb 12 12:39:37 UTC 2023  mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64 x86_64 AMD 686-class NetBSD

>Description:
I ran the atf suite (automated testing framework) on a machine, first with i386 and then the amd64 NetBSD 10.0 BETA. A few faults were specific to one architecture or the other but this result occurred on both installs. A different i386 machine did not produce the same result.

fail-i386.txt:tc, 0.031487, sbin/envstat/t_envstat, zerotemp, failed, Test case was expecting a failure but none were raised
fail-i386.txt:tp, 0.031992, sbin/envstat/t_envstat, failed 

fail-amd64.txt:tc, 0.058180, sbin/envstat/t_envstat, zerotemp, failed, Test case was expecting a failure but none were raised
fail-amd64.txt:tp, 0.058536, sbin/envstat/t_envstat, failed

XML output extract:

<tc-time>0.050701</tc-time></tc>
<tp-time>1.110082</tp-time></tp>
<tp id="sbin/envstat/t_envstat">
<tc id="zerotemp">
<so>amdtemp0 = 45.125 =~ 45</so>
<so>Skipping non-existent coretemp0</so>
<so>Skipping non-existent acpitz0</so>
<failed>Test case was expecting a failure but none were raised</failed>

Output from dmesg shows this thermal unit:

[     1.055110] amdtemp0 at amdnb_misc0: AMD CPU Temperature Sensors (Family16h)

The system board is date stamped as hp, 2014.

Running envstat produces:

$ /usr/sbin/envstat
                      Current  CritMax  WarnMax  WarnMin  CritMin  Unit
[amdtemp0]
  cpu0 temperature:    40.875                                      degC


>How-To-Repeat:
Other than a similar system board and processor, this result may not be repeatable on other systems.
>Fix:
I looked at the test source and will read more deeply in the meantime how it should work.

/usr/tests/sbin/envstat/t_envstat


[...]
                if [ $dev = "amdtemp0" ]; then
                        atf_expect_fail "PR kern/53410"
                fi