install/57100: NetBSD sysint seems to be riddled with bugs and memory corruption

[cryintothebluesky%googlemail.com@localhost]

>Number:         57100
>Category:       install
>Synopsis:       NetBSD sysint seems to be riddled with bugs and memory corruption
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Dec 10 12:55:01 +0000 2022
>Originator:     Sad Clouds
>Release:        9.99.108
>Organization:
>Environment:
>Description:
A lot of sysinst bugs seems to be in GPT partition workflow - selected options are not saved, screen partition layout menu corruption and random segfaults. The quality of of the code seems to be somewhat poor and not tested very well.
>How-To-Repeat:
Run sysint on NetBSD-current and follow these menu options:

NetBSD-9.99.108 Install System
a: Install NetBSD to hard disk

Shall we continue?
b: Yes

Available disks
a: wd0

The disk seems not to have been partitioned...
a: Guid Partition Table (GPT)

This disk matches the following BIOS disk
a: This is the correct geomety

What would you like to do
a: Set sizes of NetBSD partitions

You can now change the sizes...
x: Go on. Free space XXX MB

In the GPT partition layout select each partition and delete it, until all partitions are gone.

Now add new partitions in this order:

1. Type MSDOS, Start 1MB, Size 1MB, Newfs Yes, Mount No
2. Type FFSv2, Start 2MB, Size 1MB, Install Yes, Newfs Yes, Mount point /
3. Type FFSv2, Start 3MB, Size 1MB, Install Yes, Newfs Yes, Mount point /opt

Bug No.1 - Install and Newfs options are not saved and not displayed in flags on the menu.

Now go to partition 2, edit its property and set Install and Newfs to Yes again and select x: OK.

Now go to partition 3, edit its property and set Install and Newfs to Yes again and select x: OK.

Add another partition

4. Type FFSv2, Start 4MB, Size 1MB, Install Yes, Newfs Yes, Mount point /opt2

Bug No.2 - Partitions 2 and 3 on the layout menu have been corrupted and now display MSDOS partition.
>Fix: