Re: kern/57024: panic: solaris assert: arc_decompress(buf) == 0 (0x5 == 0x0), f ile: /home/riastradh/netbsd/current/src/sys/../external/cddl/osnet/dist/uts/common/fs/zfs/arc.c, line: 4962

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

The following reply was made to PR kern/57024; it has been noted by GNATS.

From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
To: Patrick Welche <prlw1%talktalk.net@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: kern/57024: panic: solaris assert: arc_decompress(buf) == 0 (0x5
	== 0x0), f ile:
	/home/riastradh/netbsd/current/src/sys/../external/cddl/osnet/dist/uts/common/fs/zfs/arc.c,
	line: 4962
Date: Sun, 25 Sep 2022 08:24:22 +0000

 > Date: Sun, 25 Sep 2022 07:45:01 +0000 (UTC)
 > From: Patrick Welche <prlw1%talktalk.net@localhost>
 > 
 >  +#if LZ4_ARCH64
 >  +                       if ((ref + COPYLENGTH) > oend)
 >  +#else
 >  +                       if ((ref + COPYLENGTH) > oend ||
 >  +                           (op + COPYLENGTH) > oend)
 >  +#endif
 >  +                               goto _output_error;
 >                          LZ4_SECURECOPY(ref, op, (oend - COPYLENGTH));
 >                          while (op < cpy)
 >                                  *op++ = *ref++;
 >  
 >  in commit f871ab6ea2dd (and then later replaced the whole lot with
 >  "upstream" lz4). No idea if relevant?
 
 Interesting but I don't think it's relevant, because this change only
 creates a new way for decompression to fail -- it doesn't enable it to
 decompress things like my buffer that would have failed decompression
 without the change.