NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/57005: excessive namecache purging in ufs_rmdir
The following reply was made to PR kern/57005; it has been noted by GNATS.
From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc:
Subject: Re: kern/57005: excessive namecache purging in ufs_rmdir
Date: Tue, 13 Sep 2022 01:12:55 +0000
On Mon, Sep 12, 2022 at 01:15:00AM +0000, dholland%NetBSD.org@localhost wrote:
> Call cache_purge1(dvp, cnp->cn_name, cnp->cn_namelen, 0). Unless the
> name has been trashed or something at this stage, in which case the
> name needs to be copied.
>
> Also merge the change into ulfs_vnops.c and look for additional
> cutpaste in other filesystems.
>
> XXX: this call should really be in the caller, not in every
> XXX: filesystem, but that's a bigger deal to change.
Note that rename also does similar rubbish. (These are already tagged
'XXX WTF'.)
--
David A. Holland
dholland%netbsd.org@localhost
Home |
Main Index |
Thread Index |
Old Index