Re: install/56890: sysinst should ignore default label even inDISKLABEL_NO_ONDISK_VERIFY case

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR install/56890; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: install/56890: sysinst should ignore default label even
 inDISKLABEL_NO_ONDISK_VERIFY case
Date: Sun, 19 Jun 2022 18:52:48 +0200

 On Thu, Jun 16, 2022 at 05:35:02PM +0000, Izumi Tsutsui wrote:
 >  Did you see patch in the PR?
 
 Sorry, no, had only quickly reacted on the PR in a hurry, but now had
 time to look at the issue in detail again.
 
 I like the patch, but would actually do the MD hooks change you proposed.
 How about documenting that if DISKLABEL_NO_ONDISK_VERIFY is defined, the
 MD code has to provide something like:
 
 	bool md_disklabel_is_default(const struct disklabel*);
 
 and move the two tests you implemented (for the two architectures currently
 defining DISKLABEL_NO_ONDISK_VERIFY) into their arch/md.c?
 
 FWIW: I have full amiga RDB and mac68k APM support on my post-10 todo
 list. The "clone partitions" support was supposed to help with that,
 e.g. to clone full driver, HFS or similar partitions to a new disk (w/o
 being able to create them from scratch natively).
 
 Martin