Re: port-hppa/56878 (hppa: kernel module lua fails to load)

[Nick Hudson <nick.hudson%gmx.co.uk@localhost>]

The following reply was made to PR port-hppa/56878; it has been noted by GNATS.

From: Nick Hudson <nick.hudson%gmx.co.uk@localhost>
To: Tom Lane <tgl%sss.pgh.pa.us@localhost>, gnats-bugs%netbsd.org@localhost
Cc: port-hppa-maintainer%netbsd.org@localhost
Subject: Re: port-hppa/56878 (hppa: kernel module lua fails to load)
Date: Wed, 15 Jun 2022 22:35:01 +0100

 On 15/06/2022 19:12, Tom Lane wrote:
 > Nick Hudson writes:
 >> Provide a __canonicalize_funcptr_for_compare which only needs to return
 >> the passed value as the kernel doesn't do PLABELS.
 >
 > Hmmm ... surely that should be
 >
 > Index: sys/lib/libkern/arch/hppa/milli_extra.S
 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 > RCS file: /cvsroot/src/sys/lib/libkern/arch/hppa/milli_extra.S,v
 > retrieving revision 1.1
 > diff -u -r1.1 milli_extra.S
 > --- sys/lib/libkern/arch/hppa/milli_extra.S     13 Jun 2022 16:03:07 -00=
 00      1.1
 > +++ sys/lib/libkern/arch/hppa/milli_extra.S     15 Jun 2022 17:58:02 -00=
 00
 > @@ -37,6 +37,6 @@
 >          .entry
 >
 >   MILLI_ENTRY(__canonicalize_funcptr_for_compare)
 > -       bv      %r0(%sp)
 > +       bv      %r0(%rp)
 >           copy   %arg0, %ret0
 >   EXIT(__canonicalize_funcptr_for_compare)
 
 Fixed, thanks.
 
 >
 > ???  I am not sure how come the lua test is managing to pass with
 > your version,
 
 me either... I definitely tested it and saw it pass.
 
 
 [snip]
 
 > Poking about with gdb confirms that this crash is occuring at
 > a function pointer comparison.  (BTW, I wonder how that code
 > worked at all before this patch.)
 
 Probably some more rump symbol magic, i.e. it was getting the libgcc
 version until I added the libkern version. grrrrrr rump.
 
 Thanks for spotting this.
 
 Nick