misc/56875: too-short timeout in tests/crypto/libcrypto/t_libcrypto.sh

[tgl%sss.pgh.pa.us@localhost]

>Number:         56875
>Category:       misc
>Synopsis:       too-short timeout in tests/crypto/libcrypto/t_libcrypto.sh
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 10 01:05:00 +0000 2022
>Originator:     Tom Lane
>Release:        HEAD/202206081310Z
>Organization:
PostgreSQL Global Development Group
>Environment:
NetBSD sss2.sss.pgh.pa.us 9.99.97 NetBSD 9.99.97 (SD0) #3: Thu Jun  9 15:19:02 EDT 2022  tgl%nuc1.sss.pgh.pa.us@localhost:/home/tgl/netbsd-H-202206081310Z/obj.hppa/sys/arch/hppa/compile/SD0 hppa
>Description:
The crypto/libcrypto/t_libcrypto test program sets a 720-second timeout for its bignum test step.  Slow as that sounds, it's not enough for older and slower machines.  On my HPPA 9000/360, I observe that the test step takes 1550 seconds.  I'd argue for setting the timeout well above that, since (a) this is one of the faster models of that arch, and (b) ATF tests shouldn't really assume that they'll get 100% of the CPU for long stretches.

>How-To-Repeat:
$ cd /usr/tests
$ atf-run crypto/libcrypto/t_libcrypto

>Fix:
Something like this:

Index: tests/crypto/libcrypto/t_libcrypto.sh
===================================================================
RCS file: /cvsroot/src/tests/crypto/libcrypto/t_libcrypto.sh,v
retrieving revision 1.7
diff -u -r1.7 t_libcrypto.sh
--- tests/crypto/libcrypto/t_libcrypto.sh       11 Apr 2020 16:55:33 -0000      1.7
+++ tests/crypto/libcrypto/t_libcrypto.sh       10 Jun 2022 00:50:08 -0000
@@ -39,7 +39,7 @@
 bn_head()
 {
        atf_set "descr" "Checks BIGNUM library"
-       atf_set "timeout" "720"
+       atf_set "timeout" "3600"
 }
 bn_body()
 {

although I think a good argument could be made for setting it to 2 hours (7200s) not 1.