PR/53880 CVS commit: src/include/arpa

["David H. Gutteridge" <gutteridge%netbsd.org@localhost>]

The following reply was made to PR toolchain/53880; it has been noted by GNATS.

From: "David H. Gutteridge" <gutteridge%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/53880 CVS commit: src/include/arpa
Date: Thu, 21 Apr 2022 04:03:54 +0000

 Module Name:	src
 Committed By:	gutteridge
 Date:		Thu Apr 21 04:03:54 UTC 2022
 
 Modified Files:
 	src/include/arpa: nameser_compat.h
 
 Log Message:
 nameser_compat.h: simplify logic to determine byte order
 
 There's really no need for all the complex #ifdefs present and, on top
 of that, it didn't even work correctly for all NetBSD architectures.
 Simply use endian.h and drop the rest. (Since there is no upstream for
 this code anymore, there's no concern about complicating future merges,
 either. This change is also consistent with what FreeBSD and OpenBSD
 did years ago.)
 
 Addresses PR toolchain/53880 (reported by maya@, originally encountered
 by me on macppc when building a package that pulls in nameser_compat.h
 before nameser.h by necessity -- necessity, that is, on another OS).
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.9 src/include/arpa/nameser_compat.h
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.