Re: lib/56647: Fix misbehaviour in libedit support for readline

[Christos Zoulas <christos%zoulas.com@localhost>]

The following reply was made to PR lib/56647; it has been noted by GNATS.

From: Christos Zoulas <christos%zoulas.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: lib-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 walter.lozano%collabora.com@localhost
Subject: Re: lib/56647: Fix misbehaviour in libedit support for readline
Date: Sat, 29 Jan 2022 15:53:03 -0500

 --Apple-Mail=_2EE391CB-C248-473A-A50A-B4FD774C36C5
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=us-ascii
 
 Committed!
 
 christos
 
 > On Jan 26, 2022, at 11:40 AM, Walter Lozano =
 <walter.lozano%collabora.com@localhost> wrote:
 >=20
 > The following reply was made to PR lib/56647; it has been noted by =
 GNATS.
 >=20
 > From: Walter Lozano <walter.lozano%collabora.com@localhost>
 > To: Christos Zoulas <christos%zoulas.com@localhost>, gnats-bugs%netbsd.org@localhost
 > Cc: lib-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, =
 netbsd-bugs%netbsd.org@localhost
 > Subject: Re: lib/56647: Fix misbehaviour in libedit support for =
 readline
 > Date: Wed, 26 Jan 2022 13:35:36 -0300
 >=20
 > This is a multi-part message in MIME format.
 > --------------i36T0iK89PRoJ4mZNCW6gGut
 > Content-Type: text/plain; charset=3DUTF-8; format=3Dflowed
 > Content-Transfer-Encoding: 7bit
 >=20
 > Hi Christos,
 >=20
 > On 1/24/22 15:28, Christos Zoulas wrote:
 >> Hi Walter, thanks for taking the time to write a reproducer. Just =
 attach it to a mail message
 >> and it will be added to this request. In the meantime I will commit =
 the changes.
 >=20
 > Here is the test program I use to test my changes. I this based on and
 > example I found and in the code found in connman [1][2] and bluez =
 [3][4].
 >=20
 > Unfortunately I still have issues, the message is not rendered =
 properly.
 > With the example I attach the output is
 >=20
 > WOOP> Typingwarning something needs your attentionTypingWOOP> Typing
 >=20
 > but it shoud be
 >=20
 > WOOP> Typing
 > warning something needs your attention
 > WOOP> Typing
 >=20
 > However at least now the message is seeing and the test typed is =
 restored.
 >=20
 > I'll keep trying to improve it as I still have time, but I'm not sure =
 if
 > I will be able to have a better solution.
 >=20
 > Please note that my test are done under Apertis (Linux Debian
 > derivative), but my understanding is that this type of changes should
 > apply without issues on NetBSD.
 >=20
 > Regards,
 >=20
 > Walter
 >=20
 > [1] https://salsa.debian.org/debian/connman
 > [2] https://gitlab.apertis.org/pkg/connman
 > [3] https://salsa.debian.org/bluetooth-team/bluez
 > [4] https://gitlab.apertis.org/pkg/bluez
 >=20
 >> Best,
 >>=20
 >> christos
 >>=20
 >=20
 > --
 > Walter Lozano
 > Collabora Ltd.
 > --------------i36T0iK89PRoJ4mZNCW6gGut
 > Content-Type: text/x-csrc; charset=3DUTF-8; name=3D"test.c"
 > Content-Disposition: attachment; filename=3D"test.c"
 > Content-Transfer-Encoding: base64
 >=20
 > =
 Ly8gRXhhbXBsZSBmcm9tIGh0dHA6Ly93d3cubWNsZC5jby51ay9ibG9nLzIwMDkvc2ltcGxl
 > =
 LWdudS1yZWFkbGluZS1jYWxsYmFjay1zdHlsZS1leGFtcGxlLmh0bWwKCiNpbmNsdWRlIDxz
 > =
 dGRpby5oPgojaW5jbHVkZSA8cmVhZGxpbmUvcmVhZGxpbmUuaD4KI2luY2x1ZGUgPHJlYWRs
 > =
 aW5lL2hpc3RvcnkuaD4KI2luY2x1ZGUgPHN0ZGxpYi5oPiAgLyogZm9yIGZyZWUoKSAqLwoj
 > =
 aW5jbHVkZSA8dW5pc3RkLmg+IC8qIGZvciB1c2xlZXAoKSAqLwojaW5jbHVkZSA8cHRocmVh
 > =
 ZC5oPgojaW5jbHVkZSA8c3RyaW5nLmg+CgpjaGFyIHJ1bm5pbmcgPSAxOwoKLy8gVGhlIGZ1
 > =
 bmN0aW9uIHRoYXQnbGwgZ2V0IHBhc3NlZCBlYWNoIGxpbmUgb2YgaW5wdXQKdm9pZCBteV9y
 > =
 bGhhbmRsZXIoY2hhciogbGluZSk7CnZvaWQgbXlfcmxoYW5kbGVyKGNoYXIqIGxpbmUpewog
 > =
 ICAgICAgIGlmKGxpbmU9PU5VTEwpewogICAgICAgICAgICAgICAgLy8gQ3RybC1EIHdpbGwg
 > =
 YWxsb3cgdXMgdG8gZXhpdCBuaWNlbHkKICAgICAgICAgICAgICAgIHByaW50ZigiXG5OVUxM
 > =
 QlVSR0VSXG4iKTsKICAgICAgICAgICAgICAgIHJ1bm5pbmcgPSAwOwogICAgICAgIH1lbHNl
 > =
 ewogICAgICAgICAgICAgICAgaWYoKmxpbmUhPTApewogICAgICAgICAgICAgICAgICAgICAg
 > =
 ICAgIC8vIElmIGxpbmUgd2Fzbid0IGVtcHR5LCBzdG9yZSBpdCBzbyB0aGF0IHVwYXJyb3cg
 > =
 cmV0cmlldmVzIGl0CiAgICAgICAgICAgICAgICAgICAgICAgIGFkZF9oaXN0b3J5KGxpbmUp
 > =
 OwogICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICAgICBwcmludGYoIllv
 > =
 dXIgaW5wdXQgd2FzOlxuJXNcbiIsIGxpbmUpOwogICAgICAgICAgICAgICAgICAgICAgICBm
 > =
 cmVlKGxpbmUpOwogICAgICAgIH0KfQoKLy8jZGVmaW5lIFVTRV9QUklOVEYKCnZvaWQgKiBw
 > =
 cmludF93YXJuaW5nKHZvaWQgKiBub3RoaW5nKXsKICAgICAgICBpbnQgc2F2ZWRfcG9pbnQ7
 > =
 CiAgICAgICAgY2hhciAqIHNhdmVkX2xpbmU7CgogICAgICAgIHVzbGVlcCg1MDAwMDAwKTsK
 > =
 I2lmZGVmIFVTRV9QUklOVEYKICAgICAgICBwcmludGYoIndhcm5pbmcgc29tZXRoaW5nIG5l
 > =
 ZWRzIHlvdXIgYXR0ZW50aW9uXG4iKTsKICAgICAgICBybF9yZWRpc3BsYXkoKTsKICAgICAg
 > =
 ICB1c2xlZXAoMTAwMDAwMCk7CiNlbHNlCiAgICAgICAgc2F2ZWRfcG9pbnQgPSBybF9wb2lu
 > =
 dDsKICAgICAgICBybF9zYXZlX3Byb21wdCgpOwogICAgICAgIHNhdmVkX2xpbmUgPSBybF9j
 > =
 b3B5X3RleHQoMCwgcmxfZW5kKTsKICAgICAgICBybF9yZXBsYWNlX2xpbmUoIiIsIDApOwog
 > =
 ICAgICAgIHJsX21lc3NhZ2UoIndhcm5pbmcgc29tZXRoaW5nIG5lZWRzIHlvdXIgYXR0ZW50
 > =
 aW9uXG4iKTsKICAgICAgICBybF9yZWRpc3BsYXkoKTsKICAgICAgICAvL3VzbGVlcCgxMDAw
 > =
 MDAwKTsKICAgICAgICBybF9yZXN0b3JlX3Byb21wdCgpOwogICAgICAgIHJsX3JlcGxhY2Vf
 > =
 bGluZShzYXZlZF9saW5lLCAwKTsKICAgICAgICBybF9wb2ludCA9IHNhdmVkX3BvaW50Owog
 > =
 ICAgICAgIHJsX3JlZGlzcGxheSgpOwojZW5kaWYKICAgICAgICByZXR1cm4gTlVMTDsKfQoK
 > =
 Ly8gVGhlIG1haW4gZW50cnktcG9pbnQgZm9yIHRoZSBwcm9ncmFtCmludCBtYWluKCkKewog
 > =
 ICAgICAgIGNvbnN0IGNoYXIgKnByb21wdCA9ICJXT09QPiAiOwogICAgICAgIHB0aHJlYWRf
 > =
 dCB0aHJlYWRfaWQ7CgogICAgICAgIC8vIEluc3RhbGwgdGhlIGhhbmRsZXIKICAgICAgICBy
 > =
 bF9jYWxsYmFja19oYW5kbGVyX2luc3RhbGwocHJvbXB0LCAocmxfdmNwZnVuY190KikgJm15
 > =
 X3JsaGFuZGxlcik7CgogICAgICAgIC8vIEVudGVyIHRoZSBldmVudCBsb29wIChzaW1wbGUg
 > =
 ZXhhbXBsZSwgc28gaXQgZG9lc24ndCBkbyBtdWNoIGV4Y2VwdCB3YWl0KQogICAgICAgIHJ1
 > =
 bm5pbmcgPSAxOwoKICAgICAgICBwdGhyZWFkX2NyZWF0ZSgmdGhyZWFkX2lkLCBOVUxMLCAm
 > =
 cHJpbnRfd2FybmluZywgTlVMTCk7CgogICAgICAgIHdoaWxlKHJ1bm5pbmcpewogICAgICAg
 > =
 ICAgICAgICAgLy9wcmludGYoIndhaXRpbmdcbiIpOwogICAgICAgICAgICAgICAgdXNsZWVw
 > =
 KDEwMDAwKTsKICAgICAgICAgICAgICAgIHJsX2NhbGxiYWNrX3JlYWRfY2hhcigpOwogICAg
 > =
 ICAgIH07CiAgICAgICAgcHJpbnRmKCJcbkV2ZW50IGxvb3AgaGFzIGV4aXRlZFxuIik7Cgog
 > =
 ICAgICAgIC8vIFJlbW92ZSB0aGUgaGFuZGxlcgogICAgICAgIHJsX2NhbGxiYWNrX2hhbmRs
 > ZXJfcmVtb3ZlKCk7CgogICAgICAgIHJldHVybiAwOyAvLyBoYXBweSBlbmRpbmcKfQo=3D
 >=20
 > --------------i36T0iK89PRoJ4mZNCW6gGut--
 >=20
 
 
 --Apple-Mail=_2EE391CB-C248-473A-A50A-B4FD774C36C5
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
 	filename=signature.asc
 Content-Type: application/pgp-signature;
 	name=signature.asc
 Content-Description: Message signed with OpenPGP
 
 -----BEGIN PGP SIGNATURE-----
 Comment: GPGTools - http://gpgtools.org
 
 iF0EARECAB0WIQS+BJlbqPkO0MDBdsRxESqxbLM7OgUCYfWpLwAKCRBxESqxbLM7
 OpJKAKCEq8iUZbXjQbic0yCo6TXOBs9BxgCfaorsuaD373jDnocEv1EZ+k0qxUM=
 =++SY
 -----END PGP SIGNATURE-----
 
 --Apple-Mail=_2EE391CB-C248-473A-A50A-B4FD774C36C5--