[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/56403 (memory mapped mode of wdc(4) at pcmcia(4) broken after jdolecek-ncq branch merge)
The following reply was made to PR kern/56403; it has been noted by GNATS.
From: Rin Okuyama <rokuyama.rk%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost, =?UTF-8?B?SmFyb23DrXIgRG9sZcSNZWs=?=
Subject: Re: kern/56403 (memory mapped mode of wdc(4) at pcmcia(4) broken
after jdolecek-ncq branch merge)
Date: Tue, 5 Oct 2021 16:29:00 +0900
On 2021/10/05 3:30, JaromÃr DoleÄ?ek wrote:
> Go ahead, thanks.
Thank you very much for your confirmation!
> I have only one concern, there is nothing stopping it looping forever.
> Maybe add a break condition of some sort?
I don't think that this changes cause infinite recursion:
(1) wdc_ata_bio_intr() called from c_poll (= wdc_ata_bio_poll()) asserts
ATA_ITSDONE in its error handling paths via wdc_ata_bio_done().
(2) Also, return value from c_start (= wdc_ata_bio_sart()) is checked in
So, errors encountered in c_poll and c_start routines should be handled
appropriately. The situation is similar for mvsata(4).
Still, there is a possibility where ata_xfer_start() takes long time to
finish a normal operation. This can result in bad response for lower
priority interrupts, etc.. But, I observe no such a situation, even if
heavy thrashing takes place for swap partition in wd(4) (GCC requires
more than 100MB virtual memory when compiling perl, even though my hpcsh
machine has only 32MB physical memory!!).
Main Index |
Thread Index |