[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: lib/56388: curses addstr test fails for LP64BE platforms
The following reply was made to PR lib/56388; it has been noted by GNATS.
From: Rin Okuyama <rokuyama.rk%gmail.com@localhost>
To: Brett Lymn <blymn%internode.on.net@localhost>,
Subject: Re: lib/56388: curses addstr test fails for LP64BE platforms
Date: Tue, 7 Sep 2021 10:33:51 +0900
On 2021/09/07 7:13, Brett Lymn wrote:
> On Mon, Sep 06, 2021 at 09:25:28PM +0900, Rin Okuyama wrote:
>> So, I think that check_files/addstr2.chk is generated depending on
>> ``wrong'' behavior due to the bug, and should be regenerated after
>> the bug is fixed.
> Yes, the check file should be regenerated. Initially when writing the
> tests I was manually generating the check files but this takes too much
> time and is hard to maintain so now current behaviour is captured -
> wrong or right. So, yes, if the behaviour changes when a bug is fixed
> then the check needs to be regenerated as long as the impacts on other
> tests (if any) are considered.
Committed. As far as I can see, the change does not hurt other tests.
Thank you so much for the useful comments!
Main Index |
Thread Index |