Re: kern/56355: dtrace triggers double-fault in supervisor mode

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

The following reply was made to PR kern/56355; it has been noted by GNATS.

From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
To: bch <brad.harder%gmail.com@localhost>, gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/56355: dtrace triggers double-fault in supervisor mode
Date: Sun, 15 Aug 2021 15:10:47 +0000

 > Date: Sun, 15 Aug 2021 15:08:11 +0000
 > From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
 >=20
 > > Date: Tue, 10 Aug 2021 13:26:08 -0700
 > > From: bch <brad.harder%gmail.com@localhost>
 > >=20
 > > @@ -251,8 +251,9 @@
 > >         /*
 > >          * Exclude some more symbols which can be called from probe con=
 text.
 > >          */
 > > -       if (strcmp(name, "x86_curcpu") =3D=3D 0 ||
 > > -           strcmp(name, "x86_curlwp") =3D=3D 0) {
 > > +       if (strncmp(name, "x86_curcpu", 10) =3D=3D 0 ||
 > > +           strncmp(name, "trap", 4) =3D=3D 0 ||
 > > +           strncmp(name, "x86_curlwp", 10) =3D=3D 0) {
 > >                 return 0;
 >=20
 > This patch changes the semantics of the code so that it excludes any
 > names that _start_ with `trap', `x86_curcpu', or `x86_curlwp', such as
 > `trapsignal'.  The use of strncmp instead of strcmp should be restored
 > (and the list should maybe be sorted lexicographically).
 
 Errr, I mean: this code should use strcmp, not strncmp.