Re: PR/56328 CVS commit: src/sys/arch/xen/xen

[Greg Oster <oster%netbsd.org@localhost>]

The following reply was made to PR port-xen/56328; it has been noted by GNATS.

From: Greg Oster <oster%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: PR/56328 CVS commit: src/sys/arch/xen/xen
Date: Wed, 28 Jul 2021 15:57:33 -0600

 It gets further now... but now dies at:
 [  52.3001210] panic: kernel diagnostic assertion "bcount + 
 xbd_io->xio_start_offset < VBD_VBA_SIZE" failed: file 
 "/u1/builds/build350/src/sys/arch/xen/xen/xbdback_xenbus.c", line 1314
 [  52.3001210] cpu0: Begin traceback
 [  52.3001210] vpanic() at netbsd:vpanic+0x14a
 [  52.3001210] kern_assert() at netbsd:kern_assert+0x4b
 [  52.3001210] xbdback_co_io_gotio() at netbsd:xbdback_co_io_gotio+0x3cb
 [  52.3001210] xbdback_thread() at netbsd:xbdback_thread+0x9b
 [  52.3001210] cpu0: End traceback...
 
 Thanks!
 
 On 2021-07-28 3:40 p.m., Jaromir Dolecek wrote:
 > The following reply was made to PR port-xen/56328; it has been noted by GNATS.
 > 
 > From: "Jaromir Dolecek" <jdolecek%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc:
 > Subject: PR/56328 CVS commit: src/sys/arch/xen/xen
 > Date: Wed, 28 Jul 2021 21:38:50 +0000
 > 
 >   Module Name:	src
 >   Committed By:	jdolecek
 >   Date:		Wed Jul 28 21:38:50 UTC 2021
 >   
 >   Modified Files:
 >   	src/sys/arch/xen/xen: xbdback_xenbus.c
 >   
 >   Log Message:
 >   fix intentional, but eventually faulty off-by-one for the maximum number
 >   of segments for I/O - this was supposed to allow MAXPHYS-size I/O even
 >   with page offset, but actually ended up letting through I/O up to
 >   MAXPHYS+PAGE_SIZE
 >   
 >   the KASSERT(bcount < MAXPHYS) is kept as-is, since at that place the number
 >   of segments should already be validated, so it's kernel bug if the size
 >   is still too big there
 >   
 >   fixes PR port-xen/56328 by Greg Oster
 >   
 >   
 >   To generate a diff of this commit:
 >   cvs rdiff -u -r1.97 -r1.98 src/sys/arch/xen/xen/xbdback_xenbus.c
 >   
 >   Please note that diffs are not public domain; they are subject to the
 >   copyright notices on the relevant files.
 >   
 >