re: port-i386/56280: Many asan tests are failing on i386

[matthew green <mrg%eterna.com.au@localhost>]

The following reply was made to PR port-i386/56280; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: port-i386-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost
Subject: re: port-i386/56280: Many asan tests are failing on i386
Date: Mon, 28 Jun 2021 18:43:44 +1000

 surprisingly simple to "fix" below.  probably, this needs
 to be made configureable by the platform code, rather than
 assuming 0x2000000 is right (we use 0x40000000 mostly for
 32 bit ports), or perhaps adjusting the asan code to use
 0x20000000 for netbsd/i386.
 
 
 .mrg.
 
 
 Index: gcc/config/i386/i386.c
 ===================================================================
 RCS file: /cvsroot/src/external/gpl3/gcc/dist/gcc/config/i386/i386.c,v
 retrieving revision 1.24
 diff -p -u -r1.24 i386.c
 --- gcc/config/i386/i386.c	11 Apr 2021 00:02:13 -0000	1.24
 +++ gcc/config/i386/i386.c	28 Jun 2021 08:41:44 -0000
 @@ -1399,7 +1399,7 @@ ix86_asan_shadow_offset (void)
  {
    return TARGET_LP64 ? (TARGET_MACHO ? (HOST_WIDE_INT_1 << 44)
  				     : HOST_WIDE_INT_C (0x7fff8000))
 -		     : (HOST_WIDE_INT_1 << 29);
 +		     : (HOST_WIDE_INT_1 << 30);
  }
  
  /* Argument support functions.  */