port-acorn32/56207: acorn32/earmv4: Build tree in CVS expected, compress missing

[jbglaw%lug-owl.de@localhost]

>Number:         56207
>Category:       port-acorn32
>Synopsis:       acorn32/earmv4: Build tree in CVS expected, compress missing
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-acorn32-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 24 22:35:00 +0000 2021
>Originator:     Jan-Benedict Glaw
>Release:        HEAD (github mirror, as of e47c384485123eecb84e0aa472b968a04155aa28)
>Organization:
>Environment:
>Description:
Hi!

I'm currently cross-building NetBSD targets and found that when building for acorn32 from a GIT-based source tree, ./build.sh release fails because it expects CVS directories (which it wants to remove in preparation of the ramdisk.)


$ ./build.sh -P -U -m acorn32 -a earmv4 tools
[...]
$ ./build.sh -P -U -u -m acorn32 -a earmv4 release
[...]
[bld rels 2021-05-24 15:58:42] all ===> etc/acorn32/stand
[bld rels 2021-05-24 15:58:42] rm -rf tmp
[bld rels 2021-05-24 15:58:42] mkdir tmp
[bld rels 2021-05-24 15:58:42] cp -R /var/lib/laminar/run/netbsd-acorn32-earmv4/2/NetBSD-src/distrib/acorn32/stand/BtNetBSD tmp/
[bld rels 2021-05-24 15:58:42] find tmp -path '*/CVS/*' -type f -exec rm -rf {} \;
[bld rels 2021-05-24 15:58:42] find tmp -name CVS -type d | xargs rmdir
[bld rels 2021-05-24 15:58:42] rmdir: missing operand
[bld rels 2021-05-24 15:58:42] Try 'rmdir --help' for more information.
[bld rels 2021-05-24 15:58:42]#
[bld rels 2021-05-24 15:58:42] *** Failed target:  setup_tmp
[bld rels 2021-05-24 15:58:42] *** Failed command: find tmp -name CVS -type d | xargs rmdir
[bld rels 2021-05-24 15:58:42] *** Error code 123
[bld rels 2021-05-24 15:58:42]#
[bld rels 2021-05-24 15:58:42] Stop.
[bld rels 2021-05-24 15:58:42] nbmake[4]: stopped in /var/lib/laminar/run/netbsd-acorn32-earmv4/2/NetBSD-src/distrib/acorn32/stand


This is easily being cured like this:

diff --git a/distrib/acorn32/stand/Makefile b/distrib/acorn32/stand/Makefile
index 06de69c0b14f..d3cc7325a506 100644
--- a/distrib/acorn32/stand/Makefile
+++ b/distrib/acorn32/stand/Makefile
@@ -92,7 +92,7 @@ setup_tmp:
        mkdir tmp
        cp -R ${.CURDIR}/BtNetBSD tmp/
        -find tmp -path '*/CVS/*' -type f -exec rm -rf {} \;
-       find tmp -name CVS -type d | xargs rmdir
+       -find tmp -name CVS -type d -exec rmdir {} \;
        find tmp -name '*.uue' -type f -exec rm -f {} \;
 
 .PHONY: settypes




However, scripts aren't completely happy:

[...]
[bld rels yyyy-mm-dd hh:mm:ss] cd tmp/BtNetBSD && cp -R '!BtNetBSD/native' unixfs
[bld rels yyyy-mm-dd hh:mm:ss] TOOL_MKTEMP=/var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/obj/tooldir.Linux-5.10.0-3-amd64-x86_64/bin/nbmktemp; export TOOL_MKTEMP;  TOOL_SPARKCRC=/var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/obj/tooldir.Linux-5.10.0-3-amd64-x86_64/bin/nbsparkcrc; export TOOL_SPARKCRC;  TOOL_STAT=/var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/obj/tooldir.Linux-5.10.0-3-amd64-x86_64/bin/nbstat; export TOOL_STAT;  cd tmp/BtNetBSD &&  /bin/sh /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh * > /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/obj/BtNetBSD.spk
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 168: compress: not found
[bld rels yyyy-mm-dd hh:mm:ss] /var/lib/laminar/run/netbsd-acorn32-earmv4/nn/NetBSD-src/distrib/acorn32/stand/../mksparkive.sh: 176: [: -ge: unexpected operator
[...]


>How-To-Repeat:

>Fix: