Re: install/56132: build.sh target install-image fails in update-mode

[Paul Goyette <paul%whooppee.com@localhost>]

The following reply was made to PR install/56132; it has been noted by GNATS.

From: Paul Goyette <paul%whooppee.com@localhost>
To: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: install/56132: build.sh target install-image fails in update-mode
Date: Wed, 28 Apr 2021 15:10:03 -0700 (PDT)

 On Thu, 29 Apr 2021, Izumi Tsutsui wrote:
 
 > <snip>
 >
 > Ok, I see.  ${WORKMBR} depends on ${IMAGESECTORS} and also includes
 > GPT info that depends on the image size (the secondary GPT "header"
 > is located at the end of the disk), so ${WORKMBR} should be recreated
 > if ${IMAGEMB} is changed, but there is no explicit dependecy
 > lines for it in src/distrib/common/bootimage/Makefile.bootimage.
 >
 > For workaround, it would work to make ${WORKMBR} depend on ${TARGETFS}
 > (i.e. create ${WORKMBR} after ${TARGETFS} by ${TOOL_MAKEFS} is complete).
 >
 > How about this change? (untested)
 >
 > Index: distrib/common/bootimage/Makefile.bootimage
 > ===================================================================
 > RCS file: /cvsroot/src/distrib/common/bootimage/Makefile.bootimage,v
 > retrieving revision 1.26
 > diff -u -p -d -r1.26 Makefile.bootimage
 > --- distrib/common/bootimage/Makefile.bootimage	5 Aug 2020 01:35:18 -0000	1.26
 > +++ distrib/common/bootimage/Makefile.bootimage	28 Apr 2021 19:16:04 -0000
 > @@ -499,7 +499,7 @@ ${WORKFAT}: ${TARGETFS} ${FATFILES}
 > 	    ${FATMAKEFSOPTIONS}						\
 > 	    ${WORKFAT} ${WORKFATDIR}
 >
 > -${WORKMBR}:
 > +${WORKMBR}: ${TARGETFS}
 > .if ${USE_GPT} != "no"
 > 	@echo creating GPT header and partition entries...
 > 	${RM} -f ${WORKMBR}
 
 That doesn't seem to work.  Looks like the new depedency causes a loop.
 
 ...
 /build/netbsd-local/tools/x86_64/amd64/bin/nbsed                                                         -e "s/@@MACHINE@@/amd64/"                               -e "s/@@VERSION@@/9.99.82/"                             < /build/netbsd-local/src/distrib/amd64/installimage/boot.cfg.in > boot.cfg
 nbmake[4]: Graph cycles through work.mbr   <<<<<<<<<<<<<<<<<
 create EFI system partition...
 /build/netbsd-local/tools/x86_64/amd64/bin/x86_64--netbsd-install -c -m 0644 work/usr/mdec/bootx64.efi work.efidir/EFI/boot/`basename work/usr/mdec/bootx64.efi`
 x86_64--netbsd-install: work/usr/mdec/bootx64.efi: stat: No such file or directory
 *** Failed target:  work.efi
 *** Failed command: 
 /build/netbsd-local/tools/x86_64/amd64/bin/x86_64--netbsd-install -c -m 0644 work/usr/mdec/bootx64.efi work.efidir/EFI/boot/`basename work/usr/mdec/bootx64.efi`
 *** Error code 1
 Stop.
 
 
 
 +--------------------+--------------------------+-----------------------+
 | Paul Goyette       | PGP Key fingerprint:     | E-mail addresses:     |
 | (Retired)          | FA29 0E3B 35AF E8AE 6651 | paul%whooppee.com@localhost     |
 | Software Developer | 0786 F758 55DE 53BA 7731 | pgoyette%netbsd.org@localhost   |
 +--------------------+--------------------------+-----------------------+