kern/56090: panic in udav_attach

[sc.dying%gmail.com@localhost]

>Number:         56090
>Category:       kern
>Synopsis:       panic in udav_attach
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 02 09:10:01 +0000 2021
>Originator:     sc.dying%gmail.com@localhost
>Release:        NetBSD current
>Organization:
>Environment:
System: rpi3b
Architecture: earmv7hf
Machine: evbarm
>Description:
	Kernel panics in udav_attach when udav is connected (both
	at boot and after boot) because udav_attach tries to lock the
	uninitialized mutex.
	usbnet_attach in udav_attach should be called before calling
	usbnet_{lock_core,busy}.

0xbb1bfcf4: netbsd:mutex_enter+0xc
0xbb1bfd44: netbsd:udav_attach+0x248
0xbb1bfd7c: netbsd:config_attach_loc+0x1b8
0xbb1bfde4: netbsd:usbd_attachwholedevice+0xb0
0xbb1bfe14: netbsd:usbd_probe_and_attach+0x24
0xbb1bfe7c: netbsd:usbd_new_device+0x470
0xbb1bfee4: netbsd:uhub_explore+0x2e4
0xbb1bff4c: netbsd:uhub_explore+0xd8
0xbb1bff84: netbsd:usb_discover.isra.0+0xc8
0xbb1bffac: netbsd:usb_event_thread+0x84


>How-To-Repeat:
	plug udav into the USB port of the NetBSD-current box
>Fix:
	Please move usbnet_attach before usbnet_{lock_core,busy}.