install/56062: UEFI boot code not upgraded by sysinst upgrade

[kim%netbsd.org@localhost (Kimmo Suominen)]

>Number:         56062
>Category:       install
>Synopsis:       UEFI boot code not upgraded by sysinst upgrade
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 17 07:55:00 +0000 2021
>Originator:     kim%netbsd.org@localhost (Kimmo Suominen)
>Release:        NetBSD 9.99.81
>Organization:
>Environment:
System: NetBSD rendez-vous.gw.fi 9.99.81 NetBSD 9.99.81 (GENERIC) #0: Mon Mar 15 20:18:21 UTC 2021 mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
	
	The UEFI boot code does not get upgraded when running sysinst (from
	a CD) to upgrade the system.

	# NetBSD /etc/fstab
	# See /usr/share/examples/fstab/ for more examples.
	NAME=303f60b5-697a-410b-a08b-fb272381c862	/		ffs	rw,log		 1 1
	NAME=95911f21-bdb0-4951-880a-f16570e3c7e9	/home		ffs	rw,log		 1 2
	NAME=def36e55-49f2-4d20-8144-5e5dd3f11b72	/usr		ffs	rw,log		 1 2
	NAME=7c281f0b-2cf4-4fec-beac-1bfa02db3e1e	/var		ffs	rw,log		 1 2
	NAME=339160c4-8e90-497b-8a9e-aef955be3168	none		swap	sw		 0 0
	NAME=88e0790b-c9af-4cb1-9b08-89c62c18a2d4	/p/netbsd	ffs	rw,log		 1 2
	NAME=0a0acc3b-4f50-4942-add9-9574d9c16e39	/p/sandbox	ffs	rw,log		 1 2
	tmpfs						/tmp		tmpfs	rw,-m1777,-sram%25
	kernfs						/kern		kernfs	rw,hidden
	ptyfs						/dev/pts	ptyfs	rw,hidden
	procfs						/proc		procfs	rw,hidden
	/dev/cd0a					/cdrom		cd9660	ro,noauto
	tmpfs						/var/shm	tmpfs	rw,-m1777,-sram%25

	# gpt show sd0
	     start      size  index  contents
		 0         1         PMBR
		 1         1         Pri GPT header
		 2        32         Pri GPT table
		34        30         Unused
		64    262144      1  GPT part - EFI System
	    262208    524288      2  GPT part - NetBSD FFSv1/FFSv2
	    786496   3407872      3  GPT part - NetBSD swap
	   4194368   8388608      4  GPT part - NetBSD FFSv1/FFSv2
	  12582976  12582912      5  GPT part - NetBSD FFSv1/FFSv2
	  25165888   8388511      6  GPT part - NetBSD FFSv1/FFSv2
	  33554399        32         Sec GPT table
	  33554431         1         Sec GPT header

>How-To-Repeat:
	
	Boot from a snapshot CD-ROM image and upgrade a system.

>Fix: