Re: kern/55958: pciback.hide parsing error

[Manuel Bouyer <bouyer%antioche.eu.org@localhost>]

The following reply was made to PR kern/55958; it has been noted by GNATS.

From: Manuel Bouyer <bouyer%antioche.eu.org@localhost>
To: Aleksey Arens <aza.sea.agenda%gmail.com@localhost>
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost,
        gnats-bugs%netbsd.org@localhost
Subject: Re: kern/55958: pciback.hide parsing error
Date: Tue, 26 Jan 2021 21:55:08 +0100

 On Tue, Jan 26, 2021 at 05:47:20AM -0800, Aleksey Arens wrote:
 > Adjusting the size of the static buffer path to 256 bytes had yielded
 > a positive outcome.  Adjusted /boot program had yielded a successful
 > boot on a system with BIOS firmware, and arguments to pciback were
 > interpreted correctly by the kernel subsequently.
 > 
 > ---8<---
 > [     1.000003] pciback_pci_init: hide claim device 8:0:0
 > [     1.000003] pciback_pci_init: hide claim device 1:0:1
 > [     1.000003] pciback_pci_init: hide claim device 1:0:0
 > ---8<---
 > 
 > The corresponding patch is:
 > 
 > ---8<---
 > 
 > diff --git a/sys/arch/x86/include/bootinfo.h b/sys/arch/x86/include/bootinfo.h
 > index 9d0ee542d892..6b3d967e1a7e 100644
 > --- a/sys/arch/x86/include/bootinfo.h
 > +++ b/sys/arch/x86/include/bootinfo.h
 > @@ -178,7 +178,7 @@ struct btinfo_biosgeom {
 >  };
 > 
 >  struct bi_modulelist_entry {
 > -       char path[80];
 > +       char path[256];
 >         int type;
 >         int len;
 >         uint32_t base;
 > 
 > ---8<---
 
 i'm not sure we can do this without a compatibility issue ...
 
 -- 
 Manuel Bouyer <bouyer%antioche.eu.org@localhost>
      NetBSD: 26 ans d'experience feront toujours la difference
 --