Re: PR/55945 CVS commit: src/tests/rump/rumpkern

[Andreas Gustafsson <gson%gson.org@localhost>]

The following reply was made to PR kern/55945; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: "Chuck Silvers" <chs%netbsd.org@localhost>
Cc: gnats-bugs%netbsd.org@localhost
Subject: Re: PR/55945 CVS commit: src/tests/rump/rumpkern
Date: Sat, 23 Jan 2021 12:04:04 +0200

 Chuck Silvers wrote:
 >  Module Name:	src
 >  Committed By:	chs
 >  Date:		Fri Jan 22 22:03:01 UTC 2021
 >  
 >  Modified Files:
 >  	src/tests/rump/rumpkern: t_vm.c
 >  
 >  Log Message:
 >  for the busypage test, replace atf_tc_expect_fail() with atf_tc_skip()
 >  because atf apparently has no way to expect a test program to crash.
 >  fixes PR 55945.
 >
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.5 -r1.6 src/tests/rump/rumpkern/t_vm.c
 
 For context, the previous commit (predating the PR) was:
 
   Revision 1.5
   date: 2020-12-08 19:52:11 +0200;  author: chs;  state: Exp;  lines: +2 -1;  commitid: OWDf2vgr44wLVXyC;
   the busypage test is buggy, expect it to fail.
 
 If you think a test is buggy and you can't fix it, you should file a PR
 about it and include a reference to that PR in the atf_tc_expect_fail()
 or atf_tc_skip() message.
 
 I don't think this PR should be considered "fixed" until either the
 buggy test has been fixed, or the atf_tc_skip() message contains a
 reference to a PR.
 -- 
 Andreas Gustafsson, gson%gson.org@localhost