toolchain/55879: make(1): error out on .else with extraneous text conflicts mk/readline.builtin.mk

[davshao%gmail.com@localhost]

>Number:         55879
>Category:       toolchain
>Synopsis:       make(1): error out on .else with extraneous text conflicts mk/readline.builtin.mk
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 17 08:20:00 +0000 2020
>Originator:     David Shao
>Release:        NetBSD current
>Organization:
>Environment:
NetBSD xxxxx.xxx 9.99.77 NetBSD 9.99.77 (GENERIC) #8: Wed Dec 16 22:07:32 PST 2020  xxx%xxxxxx.xxx@localhost:/usr/obj/sys/arch/amd64/compile/GENERIC amd64
>Description:
Subject: CVS commit: src/usr.bin/make
Date: Mon, 14 Dec 2020 22:17:11 +0000

make(1): error out on .else with extraneous text

causes immediate breakage using pkgsrc on NetBSD current if mk.conf has

READLINE_DEFAULT=readline

because

pkgsrc/mk/readline.builtin.mk


has around line 48

.    else if !empty(_READLINE_TYPE:Mreadline)



>How-To-Repeat:

>Fix:
While it may be argued

pkgsrc/mk/readline.builtin.mk

should be patched, it seems from pkgsrc itself that the

.else conditional

construct is not regarded as an error in practice.  NetBSD's make
seems to be rapidly updated in other BSDs which may shortly result
in surprises for them.  Therefore perhaps this change should be reverted?