Re: PR/55822 CVS commit: src/sys/dev/pci

[Bert Kiers <kiers%original.xs4all.nl@localhost>]

The following reply was made to PR kern/55822; it has been noted by GNATS.

From: Bert Kiers <kiers%original.xs4all.nl@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: yamaguchi%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost,
	kiers%original.xs4all.nl@localhost
Subject: Re: PR/55822 CVS commit: src/sys/dev/pci
Date: Tue, 1 Dec 2020 14:24:49 +0100

 On Tue, Dec 01, 2020 at 04:40:01AM +0000, Shoichi YAMAGUCHI wrote:
 > The following reply was made to PR kern/55822; it has been noted by GNATS.
 > 
 > From: "Shoichi YAMAGUCHI" <yamaguchi%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc: 
 > Subject: PR/55822 CVS commit: src/sys/dev/pci
 > Date: Tue, 1 Dec 2020 04:39:03 +0000
 > 
 >  Module Name:	src
 >  Committed By:	yamaguchi
 >  Date:		Tue Dec  1 04:39:03 UTC 2020
 >  
 >  Modified Files:
 >  	src/sys/dev/pci: if_iavf.c
 >  
 >  Log Message:
 >  Dequeue aqb from sc_atq_live even when the last command is failed
 >  
 >  iavf(4) didn't dequeue aqb from sc_atq_live that is a list for
 >  buffer in use when a command is failed by ETIMEDOUT.
 >  
 >  This causes a panic in the following sequence:
 >  
 >   1. enqueue an aqb to sc_atq_live at iavf_aqb_post()
 >   2. the last command is failed by ETIMEDOUT
 >   3. enqueue the aqb used in the failed command to sc_atq_idle
 >      at an error handling in iavf_attach()
 >   4. dequeue the same aqb from sc_atq_live and enqueue sc_atq_idle
 >      again at iavf_cleanup_admin_queue()
 >     - sc_atq_idle is broken at that time
 >   5. free the aqb in sc_atq_idle more than once
 >  
 >  Fix PR/55822
 
 This fixed the panic, but now I get
 
 iavf0 at pci0 dev 2 function 0autoconfiguration error: :unable to get VF interface version
 
 with both the 
 
 000:02:0: Intel X722 10GbE VF (ethernet network, revision 0x09)
 
 and the
 
 000:02:0: Intel XL710 Ethernet Virtual Function (ethernet network, revision 0x01)
 
 Grtnx,
 --
 Bert