xsrc/55762: libGL.so built with text relocations, fails to run

[coypu%sdf.org@localhost]

>Number:         55762
>Category:       xsrc
>Synopsis:       libGL.so built with text relocations, fails to run
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    xsrc-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Oct 28 19:45:00 +0000 2020
>Originator:     coypu
>Release:        NetBSD 9.99.74
>Organization:
>Environment:
netbsd 9.99.74 i386
>Description:
destdir.i386 [1]> env LIBGL_DRIVERS_PATH=./usr/X11R7/lib/modules/dri LIBGL_ALWAYS_SOFTWARE=1 LD_LIBRARY_PATH=./usr/X11R7/lib:./usr/lib ./usr/X11R7/bin/glxgears
./usr/X11R7/lib/libGL.so.3: text relocations
./usr/X11R7/lib/libglapi.so.1: text relocations



If adding

CFLAGS+= -Wl,--warn-shared-textrel

And rebuilding src/external/mit/xorg/lib/libGL:

ld: libGL_pic.a(entry.pico): warning: relocation against `_glapi_get_dispatch' in read-only section `.text'
warning: creating a DT_TEXTREL in a shared object

This likely occurred from disabling GLX_USE_TLS and shuffling asm code around (so now we use entry_x86_tsd.h instead of entry_x86_tls.h)

Note that we DO have:

lib/asm.mk:


X11ASM_CPPFLAGS.i386+=  \
        -DUSE_X86_ASM \
...
        -DGLX_X86_READONLY_TEXT


>How-To-Repeat:

>Fix: