NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: port-arm/55737: Apparent bug in evbarm64 DMA code causes filesystem corruption



The following reply was made to PR port-arm/55737; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%netbsd.org@localhost, skrll%netbsd.org@localhost,
    rmtodd%servalan.servalan.com@localhost
Cc: port-arm-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost
Subject: re: port-arm/55737: Apparent bug in evbarm64 DMA code causes filesystem corruption
Date: Tue, 20 Oct 2020 16:34:12 +1100

 > - fix the subset check to ensure that all the ranges in the parent tag are
 >   within the {min,max}_addr range.  If so we can just continue to use the
 >   parent tag.
 
 this part of the patch i think is problematic.
 
 previously, subset started as false, and was transitioned
 to true, and never back.
 
 now, it's as false, but it transitions back and forth to
 have the last entry's value.
 
 i think both are wrong.  it should start true, and if any
 entry is outside the parent range, set to false.
 
 
 .mrg.
 


Home | Main Index | Thread Index | Old Index