Re: port-arm/55587: ptrace tests failing

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

On 2020/08/19 19:10, martin%NetBSD.org@localhost wrote:
> In my aarch64 test runs ~50 of the ptrace tests are failing on aarch64,
> most reporting:
>
> src/tests/lib/libc/sys/t_ptrace_bytetransfer_wait.h:808: errno != EINVAL
>
> and some:
>
> src/tests/lib/libc/sys/t_ptrace_wait.h:242: Reported !exited process

For the former, return value from the fault handler was incorrect.
For the latter, test was broken. Both have been fixed.

-------- Forwarded Message --------
Subject: CVS commit: src/sys/arch/aarch64/aarch64
Date: Thu, 15 Oct 2020 22:30:34 +0000
From: Rin Okuyama <rin%netbsd.org@localhost>
Reply-To: source-changes-d%NetBSD.org@localhost
To: source-changes-full%NetBSD.org@localhost

Module Name:	src
Committed By:	rin
Date:		Thu Oct 15 22:30:34 UTC 2020

Modified Files:
	src/sys/arch/aarch64/aarch64: fault.c

Log Message:
For cpu_jump_onfault() in data_abort_handler(), stop returning
hard-coded EFAULT and use return value from uvm_fault() instead.

There are some paths that do not call uvm_fault():

(1) For fatalabort case, use EFAULT as before.
(2) When va range is invalid, use EFAULT instead of EINVAL.

These change fixes bytes_transfer_eof_* tests in
sys/lib/libc/sys/t_ptrace_wait*.

Note that without (2) above, some tests like
sys/lib/libc/sys/t_wait:write_error become newly failing.

I've confirmed that there's no new regression in full ATF run.

OK ryo


To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/arch/aarch64/aarch64/fault.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

-------- Forwarded Message --------
Subject: CVS commit: src/tests/lib/libc/sys
Date: Thu, 15 Oct 2020 22:59:50 +0000
From: Rin Okuyama <rin%netbsd.org@localhost>
Reply-To: source-changes-d%NetBSD.org@localhost
To: source-changes-full%NetBSD.org@localhost

Module Name:	src
Committed By:	rin
Date:		Thu Oct 15 22:59:50 UTC 2020

Modified Files:
	src/tests/lib/libc/sys: t_ptrace_core_wait.h

Log Message:
Apply fix in rev 1.2 for core_dump_procinfo to aarch64 and arm:

http://cvsweb.netbsd.org/bsdweb.cgi/src/tests/lib/libc/sys/t_ptrace_core_wait.h#rev1.2

> For powerpc, program counter is not automatically incremented by trap
> instruction. We cannot increment PC in the trap handler, which breaks
> applications depending on this behavior, e.g., GDB.

This statement is true for aarch64 and arm.

Also, use PTRACE_BREAKPOINT_SIZE instead of hard-coded 4 to address
instruction next to PC.

OK ryo


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libc/sys/t_ptrace_core_wait.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.