Re: port-amd64/55661: pppoe renegotiation timeout causing panic

[Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>]

Hi,

Thank you for your pointing out.

On 2020/09/16 14:30, Martin Husemann wrote:
> The following reply was made to PR port-amd64/55661; it has been noted by GNATS.
>
> From: Martin Husemann <martin%duskware.de@localhost>
> To: gnats-bugs%netbsd.org@localhost
> Cc:
> Subject: Re: port-amd64/55661: pppoe renegotiation timeout causing panic
> Date: Wed, 16 Sep 2020 07:27:22 +0200
>
>   I think the if_down "abuse" in pppoe should be removed and an internal flag
>   be set to stop reconnect attempts, to be cleared with pppoectl. But this
>   is a user visible change of behaviour - so may not be good to pullup to
>   active branches.
>   
>   A workaround would be to move LCP timeout handling from a callout to a
>   workqueue, so the if_down() call would happen in thread context (which now
>   is required).

I'm pretty sure that yamaguchi@ wrote that workqueue code.  I ask
him to commit the code after testing.


Thanks,

--
//////////////////////////////////////////////////////////////////////
Internet Initiative Japan Inc.

Device Engineering Section,
Product Development Department,
Product Division,
Technology Unit

Kengo NAKAHARA <k-nakahara%iij.ad.jp@localhost>