toolchain/55650: atf-run crashes on parse error

[roland.illig%gmx.de@localhost]

>Number:         55650
>Category:       toolchain
>Synopsis:       atf-run crashes on parse error
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 10 05:25:00 +0000 2020
>Originator:     Roland Illig
>Release:        8.0
>Organization:
>Environment:
NetBSD 8.0 amd64
>Description:
$ cd /usr/tests/usr.bin/make
$ atf-run t_make
...
terminate called after throwing an instance of 'tools::parser::parse_errors'
  what():  1: Unexpected token `-s.'; expected eof, `;' or new line
Abort trap (core dumped)

1. This should not be a crash but regular error handling.
2. The error message is missing the filename.
3. The missing filename makes it hard to identify the "1:" as being the line number.
4. The first line of "t_make" is "#! /usr/bin/atf-sh", it does not contain the token "-s." mentioned in the parse error message.
5. Changing the line to "#! /usr/bin/atf-th" yields a completely different error message:

Failed to execute 't_make': No such file or directory
tp-start: 1599715042.128949, t_make, 0
tp-end: 1599715042.128999, t_make, Invalid format for test case list: 1: Unexpected token `<<EOF>>'; expected a header name

6. The manual page of atf-run says the argument is a "test_program", and as far as I understood, "t_make" is the name of a test program.
>How-To-Repeat:

>Fix: