[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: misc/48282: Running ATF tests on 6.1.2 in KVM VPS leaves processes running
The following reply was made to PR misc/48282; it has been noted by GNATS.
From: Andreas Gustafsson <gson%gson.org@localhost>
To: gnats-bugs%NetBSD.org@localhost, christos%NetBSD.org@localhost
Subject: Re: misc/48282: Running ATF tests on 6.1.2 in KVM VPS leaves processes running
Date: Wed, 26 Aug 2020 17:11:08 +0300
The old race condition in nfsd reported in PR 48282 is back; when nfsd
daemonizes, the parent process can once again exit before the child
process is ready to provide service, because of the line
(void)write(detach_msg_pipe, "", 1);
added in 2016 by Christos' commit of nfsd.c 1.67, with the message
PR/51437: Hauke Fath: write a byte to the socket so that nfsd -u does not die.
The added line makes no sense to me, and I don't see how it could
possibly have fixed PR/51437 as claimed (but the commit of 1.68 the
next day probably did).
Since removing the line might be considered "reverting another
developer's commit" under section 11 of the NetBSD Commit Guidelines,
I'm hereby asking Christos to remove it.
Andreas Gustafsson, gson%gson.org@localhost
Main Index |
Thread Index |