NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/49390: Unsigned wraparound in tcp sequence number calculations on 64-bit machines



The following reply was made to PR kern/49390; it has been noted by GNATS.

From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/49390: Unsigned wraparound in tcp sequence number
 calculations on 64-bit machines
Date: Thu, 13 Aug 2020 06:22:15 +0300

 Oops, looks like I forgot to reference this PR in the fix I've
 committed a while ago:
 
 RCS file: /cvsroot/src/sys/netinet/tcp_output.c,v
 [...]
 revision 1.207
 date: 2018-05-08 02:42:13 +0300;  author: uwe;  state: Exp;  lines: +19 -8;  commitid: q2ycosos011hhqBA;
 Fix unsigned wraparound on window size calculations.
 
 This is another instance where tp->rcv_adv - tp->rcv_nxt can wrap
 around after successful zero-window probe from the peer.  The first
 one was fixed by chs@ in revision 1.112 on 2004-05-08.
 
 While here, CSE and de-obfuscate the code a bit.
 
 -uwe
 


Home | Main Index | Thread Index | Old Index