Re: PR/55531 CVS commit: src/usr.bin/script

[Soumendra Ganguly <soumendra%tamu.edu@localhost>]

The following reply was made to PR bin/55531; it has been noted by GNATS.

From: Soumendra Ganguly <soumendra%tamu.edu@localhost>
To: gnats-bugs <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: Re: PR/55531 CVS commit: src/usr.bin/script
Date: Sun, 2 Aug 2020 22:11:47 -0500

 Mr. Christos,
          Thank you for accepting the patch and for making the
 additional improvements. Two more things.
 
 1. err(EXIT_FAILURE, "fstat failed") in line #416 has an unnecessary
 tab character after it.
 
 2. Are static variables [ such as isterm ] initialized to 0 by the
 compiler automatically?
 
 Thank you.
 Soumendra
 
 On 8/2/20, Christos Zoulas <christos%netbsd.org@localhost> wrote:
 > The following reply was made to PR bin/55531; it has been noted by GNATS.
 >
 > From: "Christos Zoulas" <christos%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc:
 > Subject: PR/55531 CVS commit: src/usr.bin/script
 > Date: Sun, 2 Aug 2020 12:23:33 -0400
 >
 >  Module Name:	src
 >  Committed By:	christos
 >  Date:		Sun Aug  2 16:23:33 UTC 2020
 >
 >  Modified Files:
 >  	src/usr.bin/script: script.c
 >
 >  Log Message:
 >  PR/55531: Soumendra Ganguly:
 >  - add more error handling
 >  - handle -p when not a terminal
 >  - call termreset() before printing script done, so that it is printed
 > correctly
 >
 >  Also:
 >  - use ssize_t/size_t instead of int
 >  - use EXIT_SUCCESS/EXIT_FAILURE
 >  - check result of fork() against -1
 >
 >
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.22 -r1.23 src/usr.bin/script/script.c
 >
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >
 >