NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

xsrc/55500: Possible typo in bsd.x11.mk



>Number:         55500
>Category:       xsrc
>Synopsis:       Possible typo in bsd.x11.mk
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    xsrc-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 19 19:30:00 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0 and HEAD 20200719
>Organization:
>Environment:
System: NetBSD 9.0 and HEAD
Architecture: all
Machine: all
>Description:
src/share/mk/bsd.x11.mk has the following lines:
---
X11INCS.DIX=		-I${X11INCSDIR}/freetype2  \
			-I${X11INCSDIR}/pixman-1 \
---
but there is no definition for ${X11INCSDIR}.

Actually build logs around external/mit/xorg/server/xorg-server.old/glx
etc. show:
---
[..] -DHAVE_XORG_CONFIG_H -I/freetype2 -I/pixman-1 [..]
---

Note netbsd-9 and netbsd-8 have the same lines.

>How-To-Repeat:
Code and log inspection (see above).

>Fix:
Maybe they should be ${X11INCDIR}?

Index: bsd.x11.mk
===================================================================
RCS file: /cvsroot/src/share/mk/bsd.x11.mk,v
retrieving revision 1.134
diff -u -p -d -r1.134 bsd.x11.mk
--- bsd.x11.mk	23 Feb 2020 10:28:16 -0000	1.134
+++ bsd.x11.mk	19 Jul 2020 19:16:39 -0000
@@ -46,8 +46,8 @@ X11FLAGS.EXTENSION=	${X11FLAGS.BASE_EXTE
 X11FLAGS.DIX=		-DHAVE_DIX_CONFIG_H -D_BSD_SOURCE -DHAS_FCHOWN \
 			-DHAS_STICKY_DIR_BIT -D_POSIX_THREAD_SAFE_FUNCTIONS=200112L \
 			-DHAVE_XORG_CONFIG_H
-X11INCS.DIX=		-I${X11INCSDIR}/freetype2  \
-			-I${X11INCSDIR}/pixman-1 \
+X11INCS.DIX=		-I${X11INCDIR}/freetype2  \
+			-I${X11INCDIR}/pixman-1 \
 			-I$(X11SRCDIR.xorg-server)/include \
 			-I$(X11SRCDIR.xorg-server)/Xext \
 			-I$(X11SRCDIR.xorg-server)/composite \
 



Home | Main Index | Thread Index | Old Index