Re: lib/55452: ATF should not call clean-up routines for skipped tests

[Jukka Ruohonen <jruohonen%iki.fi@localhost>]

The following reply was made to PR lib/55452; it has been noted by GNATS.

From: Jukka Ruohonen <jruohonen%iki.fi@localhost>
To: Paul Goyette <paul%whooppee.com@localhost>
Cc: gnats-bugs%netbsd.org@localhost, lib-bug-people%netbsd.org@localhost,
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: lib/55452: ATF should not call clean-up routines for skipped
 tests
Date: Fri, 3 Jul 2020 18:53:31 +0300

 On Fri, Jul 03, 2020 at 08:39:48AM -0700, Paul Goyette wrote:
 > >...  the same
 > > skip-declarations need to be duplicated to the clean-up routines.
 > 
 > You still need to clean-up anything that might have been done
 > in the test-case's *_head() routine...
 
 True enough, and the noted sysctl/random_garbage is one such case. Though, 
 I wonder why the skip-declarations are not done in the head-routines? Well,
 the answer is simple at least for atf-sh-api(3):
 
 atf_test_case random_garbage cleanup
 random_garbage_head() {
         sysctl -a > $tmp
         atf_set "require.user" "root"
         atf_set "descr" "Test writing random garbage " \
                 "to sysctl nodes (PR kern/55451)"
 }
 
 So perhaps the correct approach would be to declare these in the
 init-routine; cf. the following or something alike:
 
 atf_init_test_cases() {
         atf_add_test_case random_garbage atf_skip "PR kern/55451"
 }
 
 But I guess it is easier to just duplicate the skip-declarations for the
 time being.
 
 - Jukka
 
 PS. It would be nice to also have a field in the API for PR-references.