lib/55452: ATF should not call clean-up routines for skipped tests

[jruohonen%iki.fi@localhost]

>Number:         55452
>Category:       lib
>Synopsis:       ATF should not call clean-up routines for skipped tests
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 03 15:35:00 +0000 2020
>Originator:     jruohonen%iki.fi@localhost
>Release:        NetBSD 9.99.68
>Organization:
>Environment:
System: NetBSD kafka 9.99.68 NetBSD 9.99.68 (CUSTOM) #0: Tue Jun 23 11:22:56 EEST 2020 jruoho@kafka:/tmp/obj/sys/arch/amd64/compile/CUSTOM amd64
Architecture: x86_64
Machine: amd64
>Description:
ATF calls the registered clean-up routines even when a test case has
explicitly been skipped in its body.  Although there may be some use cases
that warrant this behavior, practically all of the NetBSD test cases that
use atf_tc_skip() or atf_skip() do it as the first thing in the test cases'
bodies. By implication, and at least in some cases (e.g., a heavy clean-up
routine; see tests/sbin/ifconfig/t_random_garbage) the same
skip-declarations need to be duplicated to the clean-up routines.
>How-To-Repeat:
See, e.g., /tests/sbin/ifconfig/t_tap:
http://releng.netbsd.org/b5reports/i386/2020/2020.06.30.07.37.32/test.html#sbin_envstat_t_envstat_zerotemp
>Fix:
Do not call the clean-up routines in these special cases?