misc/55444: The last change to etc/root/dot.cshrc was incomplete

[jim.bernard%comcast.net@localhost]

>Number:         55444
>Category:       misc
>Synopsis:       The last change to etc/root/dot.cshrc was incomplete
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jul 01 18:15:00 +0000 2020
>Originator:     Jim Bernard
>Release:        src from Sun Jun 28 18:43:05 UTC 2020 20200628184305Z
>Organization:
self
>Environment:
NetBSD xxx 9.99.68 NetBSD 9.99.68 (GENERIC.202006281843Z) #0: Sun Jun 28 13:33:58 PDT 2020  root@xxx/GENERIC amd64
>Description:
The last change to ...src/etc/root/dot.cshrc was apparently intended to remove /usr/src/gnu and its subdirectories from cdpath, but the removal missed the trailing part of the outer set of nested directories.  That left three directories repeated and an unmatched right brace.  The diff relative to the previous version makes it obvious:

-set cdpath=(/usr/src/{sys,bin,sbin,usr.{bin,sbin},lib,libexec,share,local,games,gnu/{usr.{bin,sbin},libexec,lib,games}})
+set cdpath=(/usr/src/{sys,bin,sbin,usr.{bin,sbin},lib,libexec,share,local,games,libexec,lib,games}})
--------------------------------------------------------------------------------^^^^^^^^^^^^^^^^^^^

The affected revision is: $NetBSD: dot.cshrc,v 1.28 2019/12/04 08:21:50 mrg Exp $
>How-To-Repeat:
grep "set cdpath" /usr/src/etc/root/dot.cshrc

>Fix:
Remove ",libexec,lib,games}" near the end of the cdpath string.