install/55377: sysinst should explicitly note "boot partition" on partitioning

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

>Number:         55377
>Category:       install
>Synopsis:       sysinst should explicitly note "boot partition" on partitioning
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 12 17:50:00 +0000 2020
>Originator:     Izumi Tsutsui
>Release:        NetBSD 9.0
>Organization:
>Environment:
System: NetBSD 9.0 (RAMDISK) #0: Fri Feb 14 00:06:28 UTC 2020
mkrepro%mkrepro.NetBSD.org@localhost:/usr/src/sys/arch/cobalt/compile/RAMDISK
Architecture: all
Machine: all
>Description:
On several ports (evbarm RPI, arc, cobalt etc.), a "boot partition"
(FAT or Ext2fs) is necessary for their firmware to load bootstrap
binaries.

It is automatically prepared on sysinst partition editor,
but there is no info what partition it is except a directory
name "/boot". The directory (or mount point) name could be
an other names so users might remove such "unknown" partition.

>How-To-Repeat:

Use sysinst such ports and see the default partition:

---

 Free space will be added to the partition marked with a '+'.

       Size (sec)                            Filesystem
       ----------------------------------- - --------------------
   >a: 10240                                 /stand
    b: 643072 (1028784)                    + /
    c: 0                                     <swap>
    d: 0                                     /tmp (mfs)
    e: 0                                     /usr
    f: 0                                     /var
       ----------------------------------- - --------------------

---

Note "/stand" for cobalt was changed to "/ext2" on -current.
("/ext2" has been traditionally used by Cobalt Restore CD)

It's also confusing a bit showing the boot partition
at "a:" line, so it's better to explicitly denote
"this is a partition for bootstrap" etc.

>Fix:

Just add extra printf strings as "(mfs)" for /tmp:

---
RCS file: /cvsroot/src/usr.sbin/sysinst/bsddisklabel.c,v
retrieving revision 1.23.2.10
diff -u -p -d -r1.23.2.10 bsddisklabel.c
--- bsddisklabel.c	10 Feb 2020 21:39:37 -0000	1.23.2.10
+++ bsddisklabel.c	11 Jun 2020 14:25:12 -0000
@@ -258,7 +258,13 @@ draw_size_menu_line(menudesc *m, int opt
 		    pset->infos[opt].fs_version));
 		mount = swap;
 	} else if (pset->infos[opt].mount[0]) {
-		mount = pset->infos[opt].mount;
+		if (pset->infos[opt].instflags & PUIINST_BOOT) {
+			snprintf(swap, sizeof swap, "%s <boot>",
+			    pset->infos[opt].mount);
+			mount = swap;
+		} else {
+			mount = pset->infos[opt].mount;
+		}
 #ifndef NO_CLONES
 	} else if (pset->infos[opt].flags & PUIFLG_CLONE_PARTS) {
 		snprintf(swap, sizeof swap, "%zu %s",
---

The strings "<boot>" could be improved.

---
Izumi Tsutsui